Calling createOffer() on a closed peer connection has to throw an exception

RESOLVED WORKSFORME

Status

()

Core
WebRTC
P2
normal
RESOLVED WORKSFORME
6 years ago
5 years ago

People

(Reporter: whimboo, Unassigned)

Tracking

19 Branch
mozilla19
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC], [blocking-webrtc-])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
With the fix for the crash on bug 791330 I can now see that we silently hide any error. As discussed on IRC with ekr and anant we have to fire an exception whenever someone tries to call createOffer() on a closed peer connection.
(Reporter)

Comment 1

6 years ago
Created attachment 674702 [details] [diff] [review]
Fix hang in crashtest v1

This fixes the timeout for the crashtest landed with bug 791330. With the final patch on this bug you will have to update it again so it calls finish() in the catch clause.
Attachment #674702 - Flags: review?(ekr)

Updated

6 years ago
Whiteboard: [WebRTC], [blocking-webrtc-]

Updated

6 years ago
Priority: -- → P2

Comment 2

6 years ago
Comment on attachment 674702 [details] [diff] [review]
Fix hang in crashtest v1

Review of attachment 674702 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #674702 - Flags: review?(ekr) → review+
https://hg.mozilla.org/mozilla-central/rev/34b0c47186ed
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Don't know why this was marked fixed. The crashtest is fixed, but not the actual bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This appears to be fixed now. I think there was some other bug Adam fixed that fixed this issue, but I don't remember which one.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.