Closed Bug 805063 Opened 7 years ago Closed 7 years ago

Calling createOffer() on a closed peer connection has to throw an exception

Categories

(Core :: WebRTC, defect, P2)

19 Branch
defect

Tracking

()

RESOLVED WORKSFORME
mozilla19

People

(Reporter: whimboo, Unassigned)

References

Details

(Whiteboard: [WebRTC], [blocking-webrtc-])

Attachments

(1 file)

With the fix for the crash on bug 791330 I can now see that we silently hide any error. As discussed on IRC with ekr and anant we have to fire an exception whenever someone tries to call createOffer() on a closed peer connection.
This fixes the timeout for the crashtest landed with bug 791330. With the final patch on this bug you will have to update it again so it calls finish() in the catch clause.
Attachment #674702 - Flags: review?(ekr)
Whiteboard: [WebRTC], [blocking-webrtc-]
Priority: -- → P2
Comment on attachment 674702 [details] [diff] [review]
Fix hang in crashtest v1

Review of attachment 674702 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #674702 - Flags: review?(ekr) → review+
https://hg.mozilla.org/mozilla-central/rev/34b0c47186ed
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Don't know why this was marked fixed. The crashtest is fixed, but not the actual bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This appears to be fixed now. I think there was some other bug Adam fixed that fixed this issue, but I don't remember which one.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.