805063 - Calling createOffer() on a closed peer connection has to throw an exception

Status: RESOLVED WORKSFORME

(Core :: WebRTC, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the fix for the crash on bug 791330 I can now see that we silently hide any error. As discussed on IRC with ekr and anant we have to fire an exception whenever someone tries to call createOffer() on a closed peer connection.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Fix hang in crashtest v1

This fixes the timeout for the crashtest landed with bug 791330. With the final patch on this bug you will have to update it again so it calls finish() in the catch clause.

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 674702 [details] [diff] [review]
Fix hang in crashtest v1

Review of attachment 674702 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 674702 [details] [diff] [review]
Fix hang in crashtest v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/34b0c47186ed

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/34b0c47186ed

Comment 5

[Jason Smith [:jsmith]]

Don't know why this was marked fixed. The crashtest is fixed, but not the actual bug.

Comment 6

[Jason Smith [:jsmith]]

This appears to be fixed now. I think there was some other bug Adam fixed that fixed this issue, but I don't remember which one.