805142 - [browser] Adding a bookmark to home screen doesn't add it to the screen you are on

Status: VERIFIED INVALID

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

Description

[Marcia Knous [:marcia]]

Unagi device, using:
gaia revision=fcfa1857bed6596e992263206451c6814e4b2f6d
gecko revision=f58edfde05cb708f8a2c440d338f2e429aaf372b

STR:
1. Launch the browser and add a bookmark to your home screen.
2. The bookmark is added, but instead of seeing it on the screen I am on it takes me back to the blank home screen

Expected: I would see the bookmark added to the screen I am on.

Bug 796191 seems similar, but I am seeing this consistently using this build.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

see the following :
https://bugzilla.mozilla.org/show_bug.cgi?id=796819
https://github.com/mozilla-b2g/gaia/issues/5602

It's actually designed to spec to have a blank landing page.

Comment 2

[Ben Francis [:benfrancis]]

This code does not live in the browser, it lives in the homescreen.

Comment 3

[Askeing Yen[:askeing][:fyen]]

Related to https://bugzilla.mozilla.org/show_bug.cgi?id=808861

By Bug 808861, it seems fixed already.
But it can still be reproduced in the build today.

Build Info:
Gaia: 0421e603
Mozilla-beta: 117123:cf5d5b6ddee8

I'll suggest to mark it as P1 blocker, because it's a blocker of smoke test.

Comment 5

[Ben Francis [:benfrancis]]

This isn't a duplicate of bug 813384, this is about what page of the homescreen is displayed after the bookmark is added to the homescreen. The current interaction spec shows that the page the icon is added to should be displayed.

Add bookmark to homescreen is indeed broken, this is tracked by bug 813384 which therefore blocks this bug.

Comment 6

[:Margaret Leibovic]

I can't reproduce this on a build from today's mozilla-central/gaia master. On the blank home screen, I opened the browser and added a page to my homescreen, and I saw the homescreen animate to the next screen where the bookmark was added.

Comment 7

[:Margaret Leibovic]

Adding qawanted to see if this is still reproducible.

Comment 8

[Ben Francis [:benfrancis]]

Resolving as invalid following the requirements change in bug 815600 which will effect homescreen bookmarks too.

Comment 9

[Rebecca Billings [:rbillings]]

Closed as being invalid. Verified on the 12/28 unagi build that bookmark icons are added to the first available screen with icons.