Closed
Bug 805151
Opened 12 years ago
Closed 11 years ago
allow for talos to run with --develop on older versions of python
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: wlach)
Details
Attachments
(1 file)
2.30 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
While running on Talos on linux and windows while using --develop, we get this in our logs: Traceback (most recent call last): File "PerfConfigurator.py", line 864, in <module> sys.exit(main()) File "PerfConfigurator.py", line 856, in main options, args = conf.parse_args(args) File "PerfConfigurator.py", line 521, in parse_args options, args = Configuration.parse_args(self, *args, **kwargs) File "/home/cltbld/talos-slave/talos-data/talos/configuration.py", line 476, in parse_args self(*config) File "PerfConfigurator.py", line 333, in __call__ return Configuration.__call__(self, *args) File "/home/cltbld/talos-slave/talos-data/talos/configuration.py", line 380, in __call__ self.validate() File "PerfConfigurator.py", line 425, in validate self.config['webserver'] = 'localhost:%s' % utils.findOpenPort('127.0.0.1') File "/home/cltbld/talos-slave/talos-data/talos/utils.py", line 277, in findOpenPort from mozdevice import devicemanager File "/home/cltbld/talos-slave/talos-data/talos/mozdevice/__init__.py", line 5, in <module> from devicemanager import DMError File "/home/cltbld/talos-slave/talos-data/talos/mozdevice/devicemanager.py", line 526 raw_data = b"".join(b'\x00' + buf[span:span + width_byte_4] for span in range(0, (height - 1) * width * 4, width_byte_4)) can we try/except around this so we can run mozhttpd and --develop on production talos?
Assignee | ||
Comment 1•12 years ago
|
||
We could. I would prefer to just modify the methods in question not to depend on mozdevice. For findOpenPort, we could replace it with something like this: def get_open_port(): import socket s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) s.bind(("",0)) s.listen(1) port = s.getsockname()[1] s.close() return port (this is actually a bad practice which we should eventually avoid, see: https://bugzilla.mozilla.org/show_bug.cgi?id=788604#c4) For getLanIp(), we could just call into mozhttpd's iface method, something like: mozhttpd.iface.get_lan_ip()
Assignee | ||
Comment 2•12 years ago
|
||
Meh, might as well actually do the patch too.
Assignee: nobody → wlachance
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 674803 [details] [diff] [review] Remove use of mozdevice's network tools Review of attachment 674803 [details] [diff] [review]: ----------------------------------------------------------------- this looks pretty good.
Attachment #674803 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Pushed: https://tbpl.mozilla.org/?tree=Try&rev=e91a5afba8da
Reporter | ||
Comment 6•11 years ago
|
||
right now we use python 2.7 everywhere, --develop works fine, can we close this bug?
Comment 7•11 years ago
|
||
wfm; closing. Please reopen if this is still an issue.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•