805182 - [calculator] typing digits after obtaining result should start from scratch, not add digits

Status: RESOLVED WONTFIX

(Boot2Gecko Graveyard :: Gaia::Calculator, defect)

Description

[Fred Wenzel [:wenzel]]

STR:
- calculate something, like 10 * 10
- press "=", result is 100
- type something else, like a 2

Actual:
the 2 is appended to the result, you now see "1002"

Expected:
since you just saw a result, it should just clear before applying the keypress, thus only showing "2".

Note that you can keep calculating with the intermediary result, but you need to press an operator first.

Comment 1

[Josh Carpenter [:jcarpenter]]

If it's an easy fix we should fix this before release.

Comment 2

[Les Orchard [:lorchard]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6895

Pointer to Github pull-request

Comment 3

[Les Orchard [:lorchard]]

Comment on attachment 689832 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6895

Doing the attachment dance on :davidwalsh's behalf, not sure who to r? though

Comment 4

[James Lal [:lightsofapollo]]

Comment on attachment 689832 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6895

Dale should be able to review

Comment 5

[James Lal [:lightsofapollo]]

Comment on attachment 689832 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6895

Stealing review so we can go for faster turn-around. After review you will still need approval-gaia-master.

Comment 6

[James Lal [:lightsofapollo]]

Comment on attachment 689832 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6895

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 689832 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6895

Calculator is dead.