805186 - Screenshot lightbox moves vertically in Marketplace in Aurora on Android

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Maureen Hanratty]

The screenshot lightbox moves down vertically when the user is swiping through screenshots revealing a grey background. The lightbox should not be able to move vertically at all. No vertical movement on Marketplace app on Firefox OS and on Firefox on desktop browser--only seeing in on Marketplace in Aurora on Android device (I'm testing on Samsung Galaxy II)

Comment 1

[Wil Clouser [:clouserw]]

I can't reproduce this.  Can you be specific about the steps to reproduce?  (I tried nightly on android)

Comment 2

[Maureen Hanratty]

1. Go to Solitaire game on app store
2. Click on screenshot to go to lightbox
3. Swipe horizontally with your thumb to move through screenshots. You should see the screenshot lightbox move down and a grey background appear in the space between the lightbox overlay and the search bar.

Comment 3

[Maureen Hanratty]

Here's a video of what it looks like: http://www.screencast.com/t/MeCDLlvsLk

Comment 4

[Matt Basta [:basta]]

cvan: this is the issue where we need to set overflow:hidden on the body when the lightbox is open.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/5152923

Comment 6

[Victor Carciu]

The screenshot lightbox is still moving when swiping between screenshots : http://screencast.com/t/nWh2cAg8mAO

Comment 7

[Christopher Van Wiemeersch [:cvan]]

You can't prevent the browser's gray area from being exposed when you drag your fingers downward. I fixed the issue when you drag your fingers upward (or scroll downward):

http://f.cl.ly/items/2D0o3t2B3J3t1t2P0D0U/Screen%20Shot%202013-07-16%20at%2010.31.12%20AM.png

Comment 8

[Matt Basta [:basta]]

There's a bug on file for FX4A to adjust the behavior of the browser's overscroll. If I find it, I'll link it.