Created attachment 674841 [details] [diff] [review] Patch Bug 801040 tweaked the keyboard-accessible menu code, and removed the command. The command attribute did server a purpose though, as it set the label on the menuitem.
5 years ago
Created attachment 674843 [details] [diff] [review] Patch v1.1
Comment on attachment 674843 [details] [diff] [review] Patch v1.1 [Approval Request Comment] Bug caused by (feature/regressing bug #): needed to fix a regression by bug 801040 (for social api) User impact if declined: blank menuitem in tools menu Testing completed (on m-c, etc.): locally and landed on m-c Risk to taking this patch (and alternatives if risky): none expected String or UUID changes made by this patch: none
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/5bbfcd1d5296 - Impact when landed: 10 browser-chrome failures.
Oh, and my very favoritest sort of bustage: for historical reasons, Talos treats any run which has the string ERROR in allcaps in the log as a failure, and in Mac Talos other and dirtypaint you were triggering a whole lot of "Exception... "'ReferenceError: separator is not defined' when calling method: [nsIRunnable::run]" nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"
Relanded with the fixed JS, https://hg.mozilla.org/integration/mozilla-inbound/rev/6a3dbca1ca7d
Comment on attachment 674843 [details] [diff] [review] Patch v1.1 Approving for uplift (even though untracked) since it's needed for the Social API launch in 17.
Does this fix need any QA?
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #10) > Does this fix need any QA? We should be all set here.