Closed
Bug 805246
Opened 12 years ago
Closed 12 years ago
Social seems to use too much memory
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: taras.mozilla, Unassigned)
References
Details
(Keywords: meta, Whiteboard: [fx17])
Attachments
(1 obsolete file)
Using social for an hour to chat with doug ends up using over 53mb. Closing the sidebar, chatbox only cuts 10mb off.
Reporter | ||
Comment 1•12 years ago
|
||
The ui to turn off social is missing here. I tried setting social.enabled/social.active to false, but 3 facebook compartments remained.
Comment 2•12 years ago
|
||
(In reply to Taras Glek (:taras) from comment #1) > The ui to turn off social is missing here. I tried setting > social.enabled/social.active to false, but 3 facebook compartments remained. Even after minimizing memory usage?
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to Justin Lebar [:jlebar] from comment #2) > (In reply to Taras Glek (:taras) from comment #1) > > The ui to turn off social is missing here. I tried setting > > social.enabled/social.active to false, but 3 facebook compartments remained. > > Even after minimizing memory usage? yes
Comment 4•12 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=802435 just landed but didn't make it into todays nightly.
Comment 5•12 years ago
|
||
(ftr, it was worth the memory for that much time w/ taras)
Comment 6•12 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #5) > (ftr, it was worth the memory for that much time w/ taras) What do you mean?
Reporter | ||
Comment 7•12 years ago
|
||
(In reply to Taras Glek (:taras) from comment #0) > Created attachment 674880 [details] > about memory for sidebar + 1 chat box: 18.81+10.91+9.72+7.29+6.58=53.31mb > > Using social for an hour to chat with doug ends up using over 53mb. Closing > the sidebar, chatbox only cuts 10mb off. Note a similar session in facebook.com tab takes up 33mb within a single compartment
Comment 8•12 years ago
|
||
Some of this may be overhead from having several compartments (sidebar, worker, notification panels), but some of it is certainly related to the fact that facebook.com and the social feature in Firefox are separate code bases.
Comment 9•12 years ago
|
||
The attachment is wrong. Don't use "save page as" for about:memory, just copy and paste its content.
Comment 10•12 years ago
|
||
We get so many creative ways of attaching about:memory to bugs; I wonder if we can make copy/paste more discoverable.
Comment 11•12 years ago
|
||
We could add something about copy and paste to the list of instructions at the bottom. Not sure if anyone reads those, though.
Updated•12 years ago
|
Attachment #674880 -
Attachment is obsolete: true
Comment 12•12 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #11) > We could add something about copy and paste to the list of instructions at > the bottom. Not sure if anyone reads those, though. We can continue this in bug 806264.
Updated•12 years ago
|
Whiteboard: [MemShrink] → [MemShrink][fx17]
Comment 14•12 years ago
|
||
Note that bug 806264 was marked as a dup of this bug, but the report there involved a 208 MiB compartment for https://www.facebook.com/desktop/fbdesktop2/socialfox/fbworker.js.php, which is much bigger than the ones reported in this bug.
Comment 15•12 years ago
|
||
> Note that bug 806264 was marked as a dup of this bug Sorry, that should be bug 806604. 208 MiB for the fbworker compartment is a BFD, i.e. totally unacceptable. Can one of the social API guys (Jared? Gavin?) take this bug and investigate, perhaps in concert with David Ascher (from bug 806604)?
Whiteboard: [MemShrink][fx17] → [MemShrink:P1][fx17]
Comment 16•12 years ago
|
||
See https://bugzilla.mozilla.org/show_bug.cgi?id=806604#c5 for a response from one of the FB engineers. They plan to reload the worker every few hours to free up any leaked memory on their side. I'm not sure what else we can do here though. I'd love to fix it if there was something I could do though.
Comment 17•12 years ago
|
||
We have two known memory issues: one report of large use by the worker (bug 806604), and overall high use by the flyout document (I'll file that separately). Let's use this as a meta bug to track.
Reporter | ||
Comment 18•12 years ago
|
||
(In reply to Taras Glek (:taras) from comment #1) > The ui to turn off social is missing here. I tried setting > social.enabled/social.active to false, but 3 facebook compartments remained. Is anyone looking into this? Seems like the compartments should go away when social is disabled.
Comment 19•12 years ago
|
||
(In reply to Taras Glek (:taras) from comment #18) > (In reply to Taras Glek (:taras) from comment #1) > > The ui to turn off social is missing here. I tried setting > > social.enabled/social.active to false, but 3 facebook compartments remained. > > Is anyone looking into this? Seems like the compartments should go away when > social is disabled. Looks like the notification panels documents aren't being properly unloaded when the functionality is disabled. I filed bug 807532.
Depends on: 807532
Updated•12 years ago
|
Comment 20•12 years ago
|
||
I'm removing the MemShrink tag because this is a meta-bug and we have MemShrink tags on each of the blocking bugs.
Whiteboard: [MemShrink:P1][fx17] → [fx17]
Comment 21•12 years ago
|
||
There's just a single bug blocking this one now. Does this one need to still be open?
Comment 22•12 years ago
|
||
I think not.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•