805252 - [Camera] Change the identifier for nospace-text

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Staś Małolepszy :stas]

The string was changed right after the string freeze on September 28.  I now remember that David actually asked me if it was OK to land this change, but it was already late at night and I never got back to him.  Sorry, my bad!

I'll attach a patch in a moment.

Comment 1

[Staś Małolepszy :stas]

Here's the commit that changed the string:

https://github.com/mozilla-b2g/gaia/commit/1391a25a0a651db216c9efb16ba4b25ef56e891d

Comment 2

[Staś Małolepszy :stas]

Attachment: Patch

Unfortunately, I also had to change the id of nospace-title because of how the overlays are shown and hidden.

Comment 3

[david]

Comment on attachment 674889 [details] [diff] [review]
Patch

Changing review request from my personal account, where I never saw it to my work account

Comment 4

[David Flanagan [:djf]]

Comment on attachment 674889 [details] [diff] [review]
Patch

This looks fine to me. Sorry the review took so long... It went to my old pre-mozilla bugzilla account, and I never saw the request.

Comment 5

[Staś Małolepszy :stas]

Requesting blocking-basecamp.  It's a tiny change that will notify the localizers of the string change.

Comment 6

[David Scravaglieri [:scravag]]

Could you explain more ?

Comment 7

[Staś Małolepszy :stas]

The way our l10n infrastructure works, the localizers rely on changes to the identifiers to know which strings change.  If we just change the English text, the modification will go unnoticed by our reporting tools.  This patch simply changes the identifiers too, so that our tools pick it up and notify the localizers.

Comment 8

[Faramarz Rashed]

very low risk. we won't block on it but let it land due to only being a string change.

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 674889 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined:  Outdated localizations.
Testing completed: n/a
Risk to taking this patch (and alternatives if risky): none

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 674889 [details] [diff] [review]
Patch

Review of attachment 674889 [details] [diff] [review]:
-----------------------------------------------------------------

Localization only. a=me.

Comment 11

[Staś Małolepszy :stas]

https://github.com/mozilla-b2g/gaia/pull/6473
https://github.com/stasm/gaia/commit/8823685d15874c918fbc0ba82436cd3dcc782e57

Comment 12

[amiller]

Device: Unagi
Build: 20121231070201
Does not repro.