Closed Bug 805260 Opened 7 years ago Closed 7 years ago

Make errors related to not injecting mozSocial less scary

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 19

People

(Reporter: markh, Assigned: Gavin)

Details

Attachments

(1 file)

In IRC, dmose reported he is playing with the social stuff and using browserid for auth.  This process seems to involve the sidebar (and possibly other content) redirecting to browserid.org (and presumably back again) as part of the process.  However, this causes errors in the jsconsole:

dmose: Error: [Exception... "'Error: MozSocialAPI: cannot attach http://webrtc-social.herokuapp.com to https://login.persona.org/communication_iframe' when calling method: [nsIRunnable::run]" nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)" location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0" data: no]

We should tone the wording down and issue a simple wording instead.  Something like:

"The social content for http://webrtc-social.herokuapp.com is loading content from https://login.persona.org - the navigator.mozSocial interface will not be available in this window until it returns".

Or even just do nothing completely silently!  Either way, dmose thought it represented a real problem.
It's an error if we fail to do it for some other reason, but "wrong domain" should just be a warning as you suggest, yeah. I'd leave out the part about "until it returns" since that just seems confusing.
Attached patch patchSplinter Review
I moved "enabled" check out of attachToWindow and removed the reported error for that, since it should never really happen in practice.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #674912 - Flags: review?(mhammond)
Attachment #674912 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d408a2592685
Flags: in-testsuite-
OS: Windows 7 → All
Hardware: x86_64 → All
Target Milestone: --- → Firefox 19
https://hg.mozilla.org/mozilla-central/rev/d408a2592685
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.