805269 - [Contacts] Change the identifier of the show-profile string

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Staś Małolepszy :stas]

I'm not quite sure why the following change didn't make it to the files in hg.mozilla.org/gaia-l10n/en-US when we were string-freezing on September 28.

https://github.com/mozilla-b2g/gaia/commit/12a75b0821e6bf52a9a4de621a4b679101b99992#L4L97

As a result, the localizers translated the old version of the string.  To notify them of the change, we need to change the identifier.  I'll have a patch in a moment to fix this.

Comment 1

[Staś Małolepszy :stas]

Attachment: Patch

Comment 2

[Staś Małolepszy :stas]

Requesting blocking-basecamp.  We can't provide good localizations without this fix.

Comment 3

[Alex Keybl [:akeybl]]

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "remaining P1 bugs not already milestoned for C1".

Comment 4

[Alex Keybl [:akeybl]]

Stas brought to our attention that this is actually late-l10n work. Bumping up to C1 (to be completed by Nov19) given that.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 674901 [details] [diff] [review]
Patch

Stas can you make a PR against the master branch?

Comment 6

[Staś Małolepszy :stas]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6472

Pointer to Github pull-request

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 682722 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6472

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 682722 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6472

Blocking+, no need for approval.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/346efe3834a788f315476b2c6eb9c5eae4c58ead