Closed
Bug 805310
Opened 12 years ago
Closed 12 years ago
Add some docs to our object-wrapping stuff in BindingUtils.h
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
9.03 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Ms2ger asked very nicely.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #674939 -
Flags: review?(peterv)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [need review]
Comment 2•12 years ago
|
||
Thanks a lot!
Comment 3•12 years ago
|
||
Comment on attachment 674939 [details] [diff] [review] Add some documentation for our object-wrapping helpers. Review of attachment 674939 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/BindingUtils.h @@ +852,5 @@ > static inline JSObject* > WrapNativeISupportsParent(JSContext* cx, JSObject* scope, T* p, > nsWrapperCache* cache) > { > + // XXXbz should we be checking xpc_FastGetCachedWrapper here? Hmm, I don't think so (and I think we don't in nsDOMClassInfo.cpp).
Attachment #674939 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 4•12 years ago
|
||
> Hmm, I don't think so (and I think we don't in nsDOMClassInfo.cpp).
Why not, though? Seems like an obvious performance optimization, if we care about it...
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/371c850cf154 with that comment removed.
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla19
Comment 6•12 years ago
|
||
Because WrapNativeParentHelper::Wrap already checked the cache.
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/371c850cf154
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•12 years ago
|
||
Ah, so it did. Thanks!
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•