805321 - Test that page-mod w/out attachTo and attachTo frame is not attached to existing top window

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

When the new 'existing' flag was added for page mods only a test that a page-mod with a 'existing' flag was applied successfully to the top document.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Erik, could you also change the name of the test you have created for the bug 803529 with something more meaningful? The name of a test should tell what is going to be tested and "testBug803529" is not clear about that. Thanks!

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #1)
> Erik, could you also change the name of the test you have created for the
> bug 803529 with something more meaningful? The name of a test should tell
> what is going to be tested and "testBug803529" is not clear about that.
> Thanks!

I made this bug 805321 along with some other improvements to the test.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/638

Pointer to Github pull-request

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/0003a32dec53f66be4e5780c593768ffcc5774c8
bug 805321 test that a page-mod is not attached to existing documents when the existing flag is not used

https://github.com/mozilla/addon-sdk/commit/c1d8e624b71ea87ff5d2976fd8d3d8f0ec61f722
Merge pull request #638 from erikvold/805321

Fix bug 805321 Test that page-mod w/out attachTo and attachTo frame is not attached to existing top window r=@zer0