Closed
Bug 805349
Opened 13 years ago
Closed 13 years ago
Use requests module rather than home-grown helper function
Categories
(Cloud Services :: Server: Account Portal, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rfkelly, Unassigned)
Details
Attachments
(1 file)
|
4.11 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
I'd like to get rid of the mozsvc.http_helpers module, it's really just duplicating functionality that's provided in the now-standard-for-any-serious-python-toolchain "requests" module. This patch removes it from use in accountportal.
Attachment #675002 -
Flags: review?(telliott)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 675002 [details] [diff] [review]
patch to use requests module in account-portal
Seems good. Do we need any part of http_helpers still?
Attachment #675002 -
Flags: review?(telliott) → review+
|
Reporter | |
Comment 2•13 years ago
|
||
(In reply to Toby Elliott [:telliott] from comment #1)
> Do we need any part of http_helpers still?
I've replaced mozsvc.http_helpers with requests in account-portal and tokenserver. Some older products are using the http_helpers module from server-core, but nothing else uses the one from mozsvc AFAICT.
Committed in http://hg.mozilla.org/services/account-portal/rev/00d842b4d580
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•