Closed
Bug 805369
Opened 13 years ago
Closed 13 years ago
Implement lazy loading for caldav worker & shut it down when not needed.
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect, P3)
Firefox OS Graveyard
Gaia::Calendar
Tracking
(blocking-basecamp:+)
RESOLVED
FIXED
| blocking-basecamp | + |
People
(Reporter: jlal, Assigned: marijnh)
Details
(Keywords: perf, Whiteboard: [mentor=jlal@mozilla.com][LOE:S][qa-])
Attachments
(1 file)
|
46 bytes,
patch
|
jlal
:
review+
|
Details | Diff | Splinter Review |
The caldav worker takes about 3mb of memory but we only need it when syncing the calendars. Its a quick and easy win to lazy-load the worker (don't start it until the first request) and shut it down after a small period of inactivity (around 10 seconds would be appropriate).
(I am not too clear on the blocking status regarding memory usage but given that we save up to 20% of the total memory usage of calendar when not actively syncing we should do this).
The basics for this are in place already, we just need to defer the startup and implement the inactivity timeout in worker/manager.js
Updated•13 years ago
|
blocking-basecamp: ? → +
Priority: -- → P2
Updated•13 years ago
|
Priority: P2 → --
Updated•13 years ago
|
Priority: -- → P3
| Assignee | ||
Comment 1•13 years ago
|
||
I'm working on this. My bugzilla user apparently doesn't have the privilege required to assign bugs, so I'm commenting to discourage others to also start on it. If someone with privileges comes by, I'd be grateful if they'd properly assign the bug to me.
Comment 2•13 years ago
|
||
(In reply to Marijn Haverbeke from comment #1)
> I'm working on this. My bugzilla user apparently doesn't have the privilege
> required to assign bugs, so I'm commenting to discourage others to also
> start on it. If someone with privileges comes by, I'd be grateful if they'd
> properly assign the bug to me.
And...assigned!
Assignee: nobody → marijnh
Status: NEW → ASSIGNED
| Reporter | ||
Comment 3•13 years ago
|
||
Hey Marijn,
I had started a very rough patch for this I could share the (mostly-non functional) version with you it may help you get started.
| Assignee | ||
Comment 4•13 years ago
|
||
I'm at the 'almost working patch' stage, but I'd definitely be interested in your approach.
| Assignee | ||
Comment 5•13 years ago
|
||
Attachment #679650 -
Flags: review?
Updated•13 years ago
|
Attachment #679650 -
Flags: review? → review?(jlal)
| Reporter | ||
Updated•13 years ago
|
Attachment #679650 -
Flags: review?(jlal) → review+
| Reporter | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Whiteboard: [mentor=jlal@mozilla.com][LOE:S] → [mentor=jlal@mozilla.com][LOE:S][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•