805411 - Add more logcat options to mozdevice

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

It would be nice to be able to specify the format, filterspecs, as well as a list of regular expressions for us to ignore. This would help with sifting through a large log, as for example in bug 805116.

Comment 1

[William Lachance (:wlach)]

Attachment: Better logcat options for mozdevice

Here's a patch that adds some more logcat options to mozdevice (as well as cleaning up the code in general). I added a "format" option (defaulting to time), made the filterspec configurable, and added an option to allow you to pass in a list of regular expressions to ignore.

Comment 2

[William Lachance (:wlach)]

Attachment: Better logcat options for mozdevice (take 2)

Somehow accidentally attached the wrong patch. Fixed.

Here's a patch that adds some more logcat options to mozdevice (as well as cleaning up the code in general). I added a "format" option (defaulting to time), made the filterspec configurable, and added an option to allow you to pass in a list of regular expressions to ignore.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 675099 [details] [diff] [review]
Better logcat options for mozdevice (take 2)

Review of attachment 675099 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!

::: mozdevice/mozdevice/devicemanager.py
@@ +501,3 @@
>          """
> +        cmdline = ["/system/bin/logcat", "-v", format, "-d"] + filterSpecs
> +        print cmdline

Consider removing the "print". There is some value to seeing what is being filtered out, but in most applications, with simple/constant filterSpecs, it will be one more thing for our eyes to ignore ("clutter").

Comment 4

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/mozbase/commit/bbcd9b2b99cbeb64cfe2b228cbbe748d226badf9

I removed the print statement. I agree with :gbrown, that was just for debugging.