Add max length to "explain your changes" text field

RESOLVED FIXED in 2012Q4

Status

support.mozilla.org
Knowledge Base Software
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: atopal, Assigned: rrosario)

Tracking

unspecified
2012Q4

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=contributor c=wiki p=1 s=2012.21)

(Reporter)

Description

5 years ago
The maximum length for explaining changes in the "submit for review" dialog is 255 chars, but we don't tell people that and we don't restrict the text field to 255 chars. As a result submitting it with more chars shows a very unclear error message that you can't see without scrolling down the page.

Please add a maxlength to the text field.
(Assignee)

Comment 1

5 years ago
pretty easy change. just need to add an attribute to the html or tweak the form in python.
Whiteboard: u=contributor c=wiki p= s=2012.21 → u=contributor c=wiki p=1 s=2012.21
(Assignee)

Updated

5 years ago
Assignee: nobody → rrosario
(Assignee)

Comment 3

5 years ago
Landed and deployed:

https://github.com/mozilla/kitsune/commit/4db3861a1a48f45cfd59c0495ff58f5c2d88d7e6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.