805448 - Write Marionette tests for battery level changes

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

We need automated tests for the Battery API to ensure that simulated changes to the battery capacity level (level increase, level decrease) fire the appropriate events. As these tests will require simulating hardware changes, they will be necessary to run in the emulator and will therefore use Marionette.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Battery level tests. v1.0

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 690920 [details] [diff] [review]
Battery level tests. v1.0

Review of attachment 690920 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great (just a tiny nit). The test passed fine when I ran it locally (along with all of the /battery tests).

::: dom/battery/test/marionette/test_battery_level.js
@@ +35,5 @@
> +     nextFunction();
> +    };
> +    runEmulatorCmd("power capacity " + capacity);
> +  }
> +  else {

nit: have the else on the line above ie. } else {

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Sorry for the late response here, and thanks for the review. I'm in the practice of having the else on a separate line from our Mozmill style guide [1]. Is there a style guide defined for these tests that I should be following?

[1] https://developer.mozilla.org/en-US/docs/Mozmill_Tests/Mozmill_Style_Guide#Conditionals

Comment 4

[Robert Wood [:rwood]]

Ok cool - well it is just a small nit / style difference anyway. No I'm not aware of any style guide for these particular tests, I just go by the MDN coding style [1] (that doesn't specify this particular case either).

[1] https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Thanks Rob, marking as checkin-needed.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cee0b66c744c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cee0b66c744c