Closed Bug 805472 Opened 8 years ago Closed 8 years ago

[OS.File] Ensure all test files are removed

Categories

(Toolkit :: OS.File, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: andreshm, Assigned: andreshm)

Details

Attachments

(1 file, 1 obsolete file)

After running the OS.File tests, I found that there are local test files that are not being removed. We need to cleanup those files.
Attached patch Patch v1 (obsolete) — Splinter Review
Clean up test files.
Attachment #675161 - Flags: review?(dteller)
Comment on attachment 675161 [details] [diff] [review]
Patch v1

Review of attachment 675161 [details] [diff] [review]:
-----------------------------------------------------------------

Good idea and good patch, thanks a lot.

::: toolkit/components/osfile/tests/mochi/worker_test_osfile_front.js
@@ +203,5 @@
>  function test_readall_writeall_file()
>  {
>    let src_file_name = "chrome/toolkit/components/osfile/tests/mochi/worker_test_osfile_unix.js";
> +  let tmp_file_name =
> +    OS.Path.join(OS.Constants.Path.tmpDir, "test_osfile_front.tmp");

Good initiative, thanks.
Could you take this opportunity to replace src_file_name with
 OS.Path.join("chrome", "toolkit", "components", "osfile", "tests", "mochi", "worker_test_osfile_front.js")
please?
Attachment #675161 - Flags: review?(dteller) → review+
Attached patch Patch v2Splinter Review
Added changes.
Attachment #675161 - Attachment is obsolete: true
Attachment #675261 - Flags: review?(dteller)
Comment on attachment 675261 [details] [diff] [review]
Patch v2

Review of attachment 675261 [details] [diff] [review]:
-----------------------------------------------------------------

You have my r+. Thanks again.
Attachment #675261 - Flags: review?(dteller) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/48a8c0a22b24
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.