805475 - [B2G] Please add active_element property to Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Zac C (:zac)]

Please add the active_element property to Marionette.

as per:
http://code.google.com/p/selenium/wiki/JsonWireProtocol#POST_/session/:sessionId/element/active

We have discussed and think this property will be useful in the frame switching jungle that is B2G.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Is this still needed?

Comment 2

[Zac C (:zac)]

Still needed but not as a high priority.

Low-medium

Comment 3

[David Burns :automatedtester]

Desktop Try
https://tbpl.mozilla.org/?tree=Try&rev=9356626b67cd

Mobile Try
https://tbpl.mozilla.org/?tree=Try&rev=d581863b9c0a

Comment 4

[David Burns :automatedtester]

Attachment: Get Active Element on the page

Will set review when try results come in

Comment 5

[Mozilla RelEng Bot]

Try run for 9356626b67cd is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=9356626b67cd
Results (out of 10 total builds):
    success: 8
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-9356626b67cd

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 699184 [details] [diff] [review]
Get Active Element on the page

Review of attachment 699184 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the Marionette method name changed.

::: testing/marionette/client/marionette/marionette.py
@@ +488,5 @@
>          for x in response:
>              elements.append(HTMLElement(self, x))
>          return elements
>  
> +    def switch_to_active_element(self):

I think this method is poorly named; we're not switching to anything.  This just returns the active element.   We should rename this to something like 'get_active_element'.

Comment 7

[David Burns :automatedtester]

proposed method change to Selenium to keep us in line which makes our lives easier

Comment 8

[David Burns :automatedtester]

Attachment: add the ability to switch to active element in the document;

updating patch as per comments and carrying r+ forward

Comment 9

[David Burns :automatedtester]

landed on m-i 

https://hg.mozilla.org/integration/mozilla-inbound/rev/b624bea2fbe2

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/b624bea2fbe2

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/125af4e88aca

Comment 12

[Titus Fortner]

I'm still getting: "UnknownCommandError: POST /session/432419a6-def5-1f47-b9d5-1e97bd99dde1/element/active did not match a known command"

Comment 13

[Andreas Tolfsen ❲:ato❳]

Get Active Element is implemented in wires: https://github.com/jgraham/wires/blob/master/src/marionette.rs#L411

Can you recompile and check that it's accessible to you?

Comment 14

[Titus Fortner]

I'm using 0.4.2 OSX binary from release tab. I just re-downloaded to be sure.

-> POST session/b5efd61d-6b81-d64d-8e97-4b65908ae2b1/element/active

<- {"error":"unknown command","message":"POST /session/b5efd61d-6b81-d64d-8e97-4b65908ae2b1/element/active did not match a known command"}

Comment 15

[Andreas Tolfsen ❲:ato❳]

(In reply to Titus Fortner from comment #14)
> I'm using 0.4.2 OSX binary from release tab. I just re-downloaded to be sure.

I fear the download may be out of date.