805539 - [B2G] test_geolocation.js often fails on the emulator

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Jonathan Griffin (:jgriffin)]

The Marionette WebAPI test test_geolocation.js often fails on the emulator, see e.g,

https://tbpl.mozilla.org/php/getParsedLog.php?id=16458104&tree=Cedar

It will be disabled until this can be fixed, as we're trying to green up the tests so we can move them to m-c, etc.

Comment 1

[Jonathan Griffin (:jgriffin)]

test disabled: https://hg.mozilla.org/mozilla-central/rev/b3b871ca7480

Comment 2

[Jonathan Griffin (:jgriffin)]

also disabled on aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/bdb52de555e1

Comment 3

[Jonathan Griffin (:jgriffin)]

Disabled a little more thoroughly, since manifests with no active tests break tests.zip packaging:  
https://hg.mozilla.org/mozilla-central/rev/3b506ada9ef9
https://hg.mozilla.org/releases/mozilla-aurora/rev/2b2fd1afed3d

Comment 4

[Al Tsai [:atsai]]

Finding:
 The failure could cause by 2 reasons.
 The first one is emulator set a default value and the test script didn't aware it.
 The second one is network geolocation provider could give a value during a test

Comment 5

[Al Tsai [:atsai]]

Attachment: Prevent affect from default values and network geolocation provider. r=dougt

Using stack to avoid default value affect.
Adding disable network provider to avoid network geolocation provider.
It may not be the best way to disable network geolocation provider.

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 676519 [details] [diff] [review]
Prevent affect from default values and network geolocation provider. r=dougt

Review of attachment 676519 [details] [diff] [review]:
-----------------------------------------------------------------

there are more properties that you may want to verify (f.e., heading, altitude, accuracy).  Otherwise lgtm.  You should probably have one of mdas|afk, rwood, jgriffin review too.

::: dom/system/gonk/tests/marionette/test_geolocation.js
@@ +49,4 @@
>    });
> + 
> +  lat  = 0;
> +  lon = 0;   

whitespace

@@ +81,4 @@
>  
> +  cmd = "geo fix " + lon + " " + lat;
> +  sample.push(lat+"/"+lon);
> +  

extra white space

Comment 7

[Al Tsai [:atsai]]

Attachment: Remove extra whitespace

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 676519 [details] [diff] [review]
Prevent affect from default values and network geolocation provider. r=dougt

Please mark old patches as obsolete. It can be very confusing when you don't.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f8182a28d3f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f8182a28d3f

Comment 11

[Jonathan Griffin (:jgriffin)]

Will land this on aurora after verifying on cedar.

Comment 12

[Jonathan Griffin (:jgriffin)]

latest cedar runs are green

Comment 13

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/22430d341f0f