Closed Bug 805539 Opened 8 years ago Closed 8 years ago
_geolocation .js often fails on the emulator
The Marionette WebAPI test test_geolocation.js often fails on the emulator, see e.g, https://tbpl.mozilla.org/php/getParsedLog.php?id=16458104&tree=Cedar It will be disabled until this can be fixed, as we're trying to green up the tests so we can move them to m-c, etc.
test disabled: https://hg.mozilla.org/mozilla-central/rev/b3b871ca7480
also disabled on aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/bdb52de555e1
Disabled a little more thoroughly, since manifests with no active tests break tests.zip packaging: https://hg.mozilla.org/mozilla-central/rev/3b506ada9ef9 https://hg.mozilla.org/releases/mozilla-aurora/rev/2b2fd1afed3d
Finding: The failure could cause by 2 reasons. The first one is emulator set a default value and the test script didn't aware it. The second one is network geolocation provider could give a value during a test
Using stack to avoid default value affect. Adding disable network provider to avoid network geolocation provider. It may not be the best way to disable network geolocation provider.
Attachment #676519 - Flags: review?(doug.turner)
Comment on attachment 676519 [details] [diff] [review] Prevent affect from default values and network geolocation provider. r=dougt Review of attachment 676519 [details] [diff] [review]: ----------------------------------------------------------------- there are more properties that you may want to verify (f.e., heading, altitude, accuracy). Otherwise lgtm. You should probably have one of mdas|afk, rwood, jgriffin review too. ::: dom/system/gonk/tests/marionette/test_geolocation.js @@ +49,4 @@ > }); > + > + lat = 0; > + lon = 0; whitespace @@ +81,4 @@ > > + cmd = "geo fix " + lon + " " + lat; > + sample.push(lat+"/"+lon); > + extra white space
Attachment #676519 - Flags: review?(doug.turner) → review+
Attachment #676889 - Flags: review? → review?(jgriffin)
Attachment #676889 - Attachment is patch: true
Attachment #676889 - Flags: review?(jgriffin) → review+
Comment on attachment 676519 [details] [diff] [review] Prevent affect from default values and network geolocation provider. r=dougt Please mark old patches as obsolete. It can be very confusing when you don't.
Attachment #676519 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Will land this on aurora after verifying on cedar.
latest cedar runs are green
You need to log in before you can comment on or make changes to this bug.