[B2G] test_geolocation.js often fails on the emulator

RESOLVED FIXED in Firefox 18

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgriffin, Assigned: atsai)

Tracking

unspecified
mozilla19
All
Gonk (Firefox OS)
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox18 fixed, firefox19 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
The Marionette WebAPI test test_geolocation.js often fails on the emulator, see e.g,

https://tbpl.mozilla.org/php/getParsedLog.php?id=16458104&tree=Cedar

It will be disabled until this can be fixed, as we're trying to green up the tests so we can move them to m-c, etc.
(Reporter)

Comment 1

5 years ago
test disabled: https://hg.mozilla.org/mozilla-central/rev/b3b871ca7480
(Reporter)

Comment 2

5 years ago
also disabled on aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/bdb52de555e1
(Reporter)

Comment 3

5 years ago
Disabled a little more thoroughly, since manifests with no active tests break tests.zip packaging:  
https://hg.mozilla.org/mozilla-central/rev/3b506ada9ef9
https://hg.mozilla.org/releases/mozilla-aurora/rev/2b2fd1afed3d
(Assignee)

Updated

5 years ago
Assignee: nobody → atsai
(Assignee)

Comment 4

5 years ago
Finding:
 The failure could cause by 2 reasons.
 The first one is emulator set a default value and the test script didn't aware it.
 The second one is network geolocation provider could give a value during a test
(Assignee)

Comment 5

5 years ago
Created attachment 676519 [details] [diff] [review]
Prevent affect from default values and network geolocation provider. r=dougt

Using stack to avoid default value affect.
Adding disable network provider to avoid network geolocation provider.
It may not be the best way to disable network geolocation provider.
Attachment #676519 - Flags: review?(doug.turner)

Updated

5 years ago
Attachment #676519 - Attachment is patch: true

Comment 6

5 years ago
Comment on attachment 676519 [details] [diff] [review]
Prevent affect from default values and network geolocation provider. r=dougt

Review of attachment 676519 [details] [diff] [review]:
-----------------------------------------------------------------

there are more properties that you may want to verify (f.e., heading, altitude, accuracy).  Otherwise lgtm.  You should probably have one of mdas|afk, rwood, jgriffin review too.

::: dom/system/gonk/tests/marionette/test_geolocation.js
@@ +49,4 @@
>    });
> + 
> +  lat  = 0;
> +  lon = 0;   

whitespace

@@ +81,4 @@
>  
> +  cmd = "geo fix " + lon + " " + lat;
> +  sample.push(lat+"/"+lon);
> +  

extra white space
Attachment #676519 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 7

5 years ago
Created attachment 676889 [details] [diff] [review]
Remove extra whitespace
Attachment #676889 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #676889 - Flags: review? → review?(jgriffin)
(Reporter)

Updated

5 years ago
Attachment #676889 - Attachment is patch: true
(Reporter)

Updated

5 years ago
Attachment #676889 - Flags: review?(jgriffin) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Comment on attachment 676519 [details] [diff] [review]
Prevent affect from default values and network geolocation provider. r=dougt

Please mark old patches as obsolete. It can be very confusing when you don't.
Attachment #676519 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f8182a28d3f
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7f8182a28d3f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(Reporter)

Comment 11

5 years ago
Will land this on aurora after verifying on cedar.
Whiteboard: [automation-needed-in-aurora]
(Reporter)

Comment 12

5 years ago
latest cedar runs are green
(Reporter)

Comment 13

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/22430d341f0f
status-firefox18: --- → fixed
status-firefox19: --- → fixed
Whiteboard: [automation-needed-in-aurora]
You need to log in before you can comment on or make changes to this bug.