805549 - signaling_sipcc fails to compile because of unused variable

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P3)

Description

[Wolfgang Rosenauer [:wolfiR]]

Trying to compile current mozilla-aurora fails with:

[  813s] CC_SIPCCLine.cpp
[  813s] /home/abuild/rpmbuild/BUILD/mozilla/media/webrtc/signaling/src/sipcc/core/common/config_parser.c: In function 'config_setup_elements':
[  813s] /home/abuild/rpmbuild/BUILD/mozilla/media/webrtc/signaling/src/sipcc/core/common/config_parser.c:410:10: error: unused variable 'buf' [-Werror=unused-variable]
[  813s] cc1: all warnings being treated as errors
[  813s] make[7]: *** [src/sipcc/core/common/config_parser.o] Error 1

The created CPPFLAGS contain -Werror

Either -Werror or the unused variable has to go.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

next one:
[  779s] CC_SIPCCFeatureInfo.cpp
[  779s] /home/abuild/rpmbuild/BUILD/mozilla/media/webrtc/signaling/src/sipcc/core/common/misc.c:98:1: error: 'set_month_from_str' defined but not used [-Werror=unused-function]
[  779s] cc1: all warnings being treated as errors

Wondering why that apparently only happens to me and not break in continuous builds.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

It may depend on compiler version, options, etc.

We've made fixes for this in m-c; I'll see if they've been uplifted and nominate them

Comment 3

[Adam Roach [:abr]]

(In reply to Randell Jesup [:jesup] from comment #2)
> It may depend on compiler version, options, etc.
> 
> We've made fixes for this in m-c; I'll see if they've been uplifted and
> nominate them

I have *got* to imagine this is fixed everywhere relevant by now, given that the fix apparently landed in m-c six months ago. Closing.