Closed Bug 805569 Opened 13 years ago Closed 10 years ago

Remove anchor element in the segmented-button for about:reader

Categories

(Firefox for Android Graveyard :: Reader View, defect, P4)

Product:
Firefox for Android Graveyard
Component:
Reader View
Platform:
ARM
Android
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1120004

People

(Reporter: jwir3, Assigned: jwir3)

Details

The segmented button element (e.g. "Light" and "Dark") has an anchor element in it that could probably be removed. Instead, we could place the text directly in the <li> parent element. Further, we can probably remove the dynamic generation of this element from the aboutReader.js script, and instead, place it directly into the HTML.
The inner anchor element is there because the selected state (different bg color) is smaller than the area of the li element. If you can achieve the same without the anchor element, I'm fine with it. As for the dynamic generation, this is basically because I wasn't sure how to use translatable strings inside the HTML. Feel free to change it if you know how to do it.
Priority: -- → P4
I'm fixing this in bug 1120004.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.