805569 - Remove anchor element in the segmented-button for about:reader

Status: RESOLVED DUPLICATE of bug 1120004

Description

[Scott Johnson (:jwir3)]

The segmented button element (e.g. "Light" and "Dark") has an anchor element in it that could probably be removed. Instead, we could place the text directly in the <li> parent element. Further, we can probably remove the dynamic generation of this element from the aboutReader.js script, and instead, place it directly into the HTML.

Comment 1

[Lucas Rocha (:lucasr)]

The inner anchor element is there because the selected state (different bg color) is smaller than the area of the li element. If you can achieve the same without the anchor element, I'm fine with it.

As for the dynamic generation, this is basically because I wasn't sure how to use translatable strings inside the HTML. Feel free to change it if you know how to do it.

Comment 2

[:Margaret Leibovic]

I'm fixing this in bug 1120004.