Remove GeckoApp.sIsGeckoReady

RESOLVED FIXED in Firefox 19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

unspecified
Firefox 19
x86
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
GeckoApp.sIsGeckoReady appears to be redundant. We should use GeckoApp.LaunchState instead.
(Assignee)

Comment 1

6 years ago
Created attachment 675708 [details] [diff] [review]
code cleanup: remove sIsGeckoReady

This is a pretty trivial change: sIsGeckoReady -> checkLaunchState(LaunchState.GeckoRunning), suggested by :blassey. 

Strictly speaking sIsGeckoReady is equivalent to checkLaunchState(GeckoRunning) || checkLaunchState(GeckoExiting), but as sIsGeckoReady is used, I think it is safe to eliminate the exiting cases.
Attachment #675708 - Flags: review?(bugmail.mozilla)
Comment on attachment 675708 [details] [diff] [review]
code cleanup: remove sIsGeckoReady

Review of attachment 675708 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #675708 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/fdefe523f873
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.