Closed
Bug 805600
Opened 12 years ago
Closed 12 years ago
Remove GeckoApp.sIsGeckoReady
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 19
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
|
4.20 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
GeckoApp.sIsGeckoReady appears to be redundant. We should use GeckoApp.LaunchState instead.
|
Assignee | |
Comment 1•12 years ago
|
||
This is a pretty trivial change: sIsGeckoReady -> checkLaunchState(LaunchState.GeckoRunning), suggested by :blassey.
Strictly speaking sIsGeckoReady is equivalent to checkLaunchState(GeckoRunning) || checkLaunchState(GeckoExiting), but as sIsGeckoReady is used, I think it is safe to eliminate the exiting cases.
Attachment #675708 -
Flags: review?(bugmail.mozilla)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 675708 [details] [diff] [review]
code cleanup: remove sIsGeckoReady
Review of attachment 675708 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #675708 -
Flags: review?(bugmail.mozilla) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•