805666 - [Clock] Clock takes a long time to repaint

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect, P3)

Description

[Dave Townsend [:mossop]]

The analog clock takes an age to paint itself. You can go in, open an alarm then close it and it takes around 2 seconds to fully draw the clock background.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Hey guys, are we using a CSS radial gradient for the background here?

Unfortunately, that's just about the slowest CSS primitive on ARM devices, and there's nothing we can do about it in the v1 timeframe :(.  Pre-rasterizing the background is unfortunately the way we need to go.  Ideally with a media query that only does it for low-resolution screens.

Comment 2

[Patryk Adamczyk [:patryk] UX]

Yes, at current load speeds, I would deem this shippable. I will work with Peter to reduce the effects and increase the load performance.

Comment 3

[Patryk Adamczyk [:patryk] UX]

(In reply to Patryk Adamczyk [:patryk] UX from comment #2)
> Yes, at current load speeds, I would deem this shippable.

I mean "unshippable" at current speeds.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I would recommend not changing the effect, but just producing a static .png or .jpg for HVGA resolution.

Comment 5

[David Scravaglieri [:scravag]]

Polish / perf issue so not blocking

Comment 6

[[e-mail], [e-mail]]

The following patch will improve the repainting time.
https://github.com/mozilla-b2g/gaia/pull/6082

Use small resolution(320x460) image on Ototro.
It will improve loading time for the background image.

Could we fix the issue by the pull request?

Comment 7

[Andreas Gal :gal]

The clock app also uses lots of SVG gradients. We have to stop that. Patryk can you supply bitmap images for the various clock parts please?

Comment 8

[[e-mail], [e-mail]]

Since the pr https://github.com/mozilla-b2g/gaia/pull/6082 was merged,
I'm not sure that the repaint time is accepted or not.

Comment 9

[Patryk Adamczyk [:patryk] UX]

Gordon and I will strip out the graphics and do a graphic swap next week to help the performance.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/39fbddb076403edffaf5260d20825c92dab177c6