805700 - Enable use of hardware H.264/AAC/MP3 decoders in Android libstagefright omx plugin for HC

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Maire Reavy [:mreavy]]

Bug 782508 added support for the hardware decoders accessible via libstagefright for Android ICS/JB.  Bug 787228 adds hardware decoding support for GB (Gingerbread).  This adds hardware decoding support for HC (Honeycomb).

Comment 1

[Maire Reavy [:mreavy]]

What would be a good HC device for Chris Double to use in his testing?

Comment 2

[cajbir (:cajbir)]

Whatever device you provide for testing is probably the only one that will work. AFAIK there's no official HC source release so there's no telling what stagefright libraries are on them.

Comment 3

[Maire Reavy [:mreavy]]

(In reply to Chris Double (:doublec) from comment #2)
> Whatever device you provide for testing is probably the only one that will
> work. AFAIK there's no official HC source release so there's no telling what
> stagefright libraries are on them.

Google never officially released any of the 3.x software, but all the 3.x software was released as part of 4.0.  The kicker is that there aren't any tags that would allow one to pull out a specific Honeycomb release: http://arstechnica.com/gadgets/2011/11/google-makes-android-4-source-code-available/ 

Questions for the Android folks: Is there a specific list of HC devices that we care about?  How big is it?  Does Chris Double need to do a custom solution for every HC device we want to add to the whitelist, or is there another way?

Comment 4

[cajbir (:cajbir)]

It's possible the work for one device will work on others of course. My comment was geared towards making sure whatever device you send to me is a device you need to work in the field vs some random device that just happens to run honeycomb that you don't otherwise care about. This will make sure that at least one important device is supported.

Comment 5

[Ralph Giles (:rillian)]

The Samsung Galaxy Tab and Asus Transformer were two popular honeycomb tablets. If you can find one that hasn't been updated.

I upgraded mine without making a backup, but e.g. the vidyo tablet in Wreck at the Vancouver office is running 3.2.

Comment 6

[Maire Reavy [:mreavy]]

(In reply to Ralph Giles (:rillian) from comment #5)
> The Samsung Galaxy Tab and Asus Transformer were two popular honeycomb
> tablets. If you can find one that hasn't been updated.

blassey, cpeterson-- Can we get one of those (with HC installed) shipped to doublec in NZ?
Can I just file a request with mozilla.service-now.com like I did for the GB device?  Would you be happy with either of those as our first supported HC device?  Thanks.

Comment 7

[Chris Peterson [:cpeterson]]

Both the Asus Transformer (Prime) and Galaxy Tab are available on Service Now. You should be able to just order them there:

https://mozilla.service-now.com/catalog_home.do?sysparm_view=tablets

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

I'm fairly sure the Prime shipped ICS.

Comment 9

[Maire Reavy [:mreavy]]

(In reply to Chris Peterson (:cpeterson) from comment #7)
> Both the Asus Transformer (Prime) and Galaxy Tab are available on Service
> Now. You should be able to just order them there:
> 
> https://mozilla.service-now.com/catalog_home.do?sysparm_view=tablets

I followed that link and 3 tablets are shown as available for shipment:
ASUS Transformer Prime
Google Nexus 7
Samsung Galaxy Tab2 

All of them ship with ICS or JB -- none with HC.  So, what HC device should we target as our first device to get working (it needs to be one that we can ship to Chris Double)?

Comment 10

[Kevin Brosnan [Ex-Mozilla]]

It may require going to Ebay or similar to get a Honeycomb device.

Comment 11

[Jonathan Lin - Not watching NI/offline [:jlin] [[e-mail]]]

We have a Galaxy Tab 10.1 (GT-P7510) in Toronto running 3.1 that will be shipped over to YVR for the work week, for Chris Double or Roc. Asset Tag # 05460

Comment 12

[Maire Reavy [:mreavy]]

roc, doublec -- The easiest way to get a HC device to you guys in NZ is to ship it to Vancouver for the Media work week and then have one of you hand carry it home.  Can one of you hand carry it to NZ?  Assuming of course you don't get it working in Vancouver. :-)

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes, we can bring it back.

Comment 14

[Aaron Train [:aaronmt]]

(In reply to Ralph Giles (:rillian) from comment #5)
> The Samsung Galaxy Tab and Asus Transformer were two popular honeycomb
> tablets. If you can find one that hasn't been updated.
> 
> I upgraded mine without making a backup, but e.g. the vidyo tablet in Wreck
> at the Vancouver office is running 3.2.

XDA will more than likely have a community thread with stock images for the exact model

Comment 15

[Maire Reavy [:mreavy]]

We found a second Galaxy Tab 10.1 running Honeycomb (version 3.2) and Rob (roc) now has it.  Rob is bringing it to the Media work week in Vancouver.  

So I think we now have 3 Galaxy Tab 10.1 (one running 3.1 and two running 3.2) for development and QA.

Comment 16

[cajbir (:cajbir)]

I've done some preliminary investigation on the HC 3.2 tablet. Once again using our own derived DataSource causes crashes but using the DataSource provided by DataSource::CreateFromURI playback works.

I'm investigating what the differences are.

Comment 17

[cajbir (:cajbir)]

Playback is working on Honeycomb 3.2 now with some minor changes to the Gingerbread support. The commit id from the Android source that I based the changes to DataSource from is c2dc4729e3c88d733c0aa6d9a9af6101b2f09e35:

commit c2dc4729e3c88d733c0aa6d9a9af6101b2f09e35
Author: Gloria Wang <[e-mail]>
Date:   Mon Feb 7 11:41:11 2011 -0800

    - Do not use global DrmManagerClient
    - Release the DrmManagerClient and DecryptHandle in DataSource
    Fix for bug 3429811
    
    Change-Id: I549f72b75225751877eb0e630ce8098f8ec6316f

commit b1262a8b1dd23abad64465f9ffd25c44facdf4d2
Author: James Dong <[e-mail]>
Date:   Tue Nov 16 14:04:54 2010 -0800

    64-bit file size/offset support for media framework
    
    Change-Id: I3452bc2c0f1d990cc67285df2fce1f9f86ff8e10


This was identified based on inspection of the DataSource changes in the commits and comparing against the unmangled C++ method names in libstagefright.so on the device.

Comment 18

[Chris Peterson [:cpeterson]]

doublec, so DataSource uses off64_t in Honeycomb and later, but 32-bit off_t in Gingerbread and earlier?

Comment 19

[cajbir (:cajbir)]

cpeterson, off64_t in 2.3.6 and later. off_t in 2.3.4 and less. Not sure about 2.3.5 haven't checked or seen a device with it.

Comment 20

[Chris Peterson [:cpeterson]]

FYI, my Galaxy Note has 2.3.5 and it looks like its libstagefright.so uses a 32-bit off_t:

  android::FileSource::readAt(long offset, void *data, size_t size)

Comment 21

[Maire Reavy [:mreavy]]

So it sounds like we have decoding working on 2.3.6 and later?  Does decoding work yet on versions 2.3.5 and earlier?

Comment 22

[cajbir (:cajbir)]

(In reply to Maire Reavy [:mreavy] from comment #21)
> So it sounds like we have decoding working on 2.3.6 and later?  Does
> decoding work yet on versions 2.3.5 and earlier?

I don't have decoding working consistently on GB yet (2.3.x).

Comment 23

[cajbir (:cajbir)]

Attachment: work in progress patch

This patch applied to mozilla-central gives support for libstagefright decoding on honeycomb devices. It includes current work in progress patches for gingerbread. I'll continue trying to get GB working and clean the code up for review over the next day or two.

To test you'll need to set the pref stagefright.force-enabled to true.

Comment 24

[cajbir (:cajbir)]

Attachment: Part1: omx plugin changes for Honeycomb support

Requires bug 787228 patches to be applied first.

Comment 25

[cajbir (:cajbir)]

Attachment: Part2: Package honeycomb libomxplugin libraries on Android

Comment 26

[cajbir (:cajbir)]

Attachment: Part3: Build changes for honeycomb libomxplugin libraries on Android

Comment 27

[cajbir (:cajbir)]

Attachment: Part1: omx plugin changes for Honeycomb support

Original patch was missing some changes.

Comment 28

[Chris Peterson [:cpeterson]]

Comment on attachment 685481 [details] [diff] [review]
Part1: omx plugin changes for Honeycomb support

Review of attachment 685481 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 29

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ec8feec4ae1
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2dd27b5985c
https://hg.mozilla.org/integration/mozilla-inbound/rev/06dfb6d9f0c0

Comment 30

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ec8feec4ae1
https://hg.mozilla.org/mozilla-central/rev/d2dd27b5985c
https://hg.mozilla.org/mozilla-central/rev/06dfb6d9f0c0