Open Bug 805769 Opened 10 years ago Updated 2 years ago

Unify the weak maps for pause and thread-lifetime actors

Categories

(DevTools :: Debugger, task, P5)

task

Tracking

(Not tracked)

People

(Reporter: past, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Now that upgrading a pause-lifetime actor to a thread-lifetime one does not alter its ID, we can unify the weak maps we use to retrieve the actors.
Attached patch Patch v1Splinter Review
WIP. Breaks a few tests.
I no longer have the time to work on this.
Assignee: past → nobody
Status: ASSIGNED → NEW
Product: Firefox → DevTools
Priority: P2 → P3
Logan this looks like a nice win, what do you think?
Flags: needinfo?(lsmyth)
the code has shifted, but this still looks relevant. 
https://searchfox.org/mozilla-central/source/devtools/server/actors/thread.js
Flags: needinfo?(poirot.alex)

TBH, I don't really know this precise code.

But generally, note that manually managed ActorPool might be simplified if we convert the actor to protocol.js Actor.
Actor are pools and you can register the child actors to the base actor, if the child actor lifetime is the same than the base actor. Otherwise, you still need a dedicated ActorPool, so that you can destroy the pool individually and keep the base actor alive.

Flags: needinfo?(poirot.alex)

Also not that familiar, but this does seem reasonable from what I've seen.

Flags: needinfo?(lsmyth)
Type: defect → task
Priority: P3 → P5
You need to log in before you can comment on or make changes to this bug.