Status

Release Engineering
General Automation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 675535 [details] [diff] [review]
util.commands fixes

* copy kwargs before modifying it
* use subprocess.list2cmdline instead of escape
* PEP8
Attachment #675535 - Flags: review?(bhearsum)
Comment on attachment 675535 [details] [diff] [review]
util.commands fixes

Review of attachment 675535 [details] [diff] [review]:
-----------------------------------------------------------------

list2cmdline isn't technically a public method, but docstring in http://svn.python.org/projects/python/trunk/Lib/subprocess.py makes it seem like it's pretty safe to rely on.
Attachment #675535 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.