80583 - Ability to use a different gtk-theme for mozilla

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, enhancement, P1)

Description

[martin.storsjo]

I'm using quite a dark gtk-theme. This doesn't look too good in Mozilla, but I
thought it would be possible to fix this for myself with a small hack, by
setting the GTK_RC_FILES-environment variable to point to the default theme
before starting Mozilla. This is a standard gtk-variable and works for all
"normal" gtk-applications. Too bad Mozilla doesn't read this variable.

Implementing this wouldn't bee too hard, and would be very useful, at least for me.

Comment 1

[Boris Zbarsky [:bzbarsky]]

How does this avariable work exactly?  Does it just point to the directory in
which the .gtkrc that the app is supposed to read lives?  Or does it point to an
actual file to be read instead of .gtkrc?

Comment 2

[martin.storsjo]

It consists of a list of gtkrc-files to be read instead of ~/.gtkrc. Code
example from gtkrc.c in gtk+-1.2.9:

  var = getenv("GTK_RC_FILES");
  if (var)
    {
      files = g_strsplit (var, ":", 128);
      i=0;
      while (files[i])
	{
	  gtk_rc_add_default_file (files[i]);
	  i++;
	}
      g_strfreev (files);
    }
  else
    {
      str = g_strdup_printf ("%s%s", GTK_SYSCONFDIR, "/gtk/gtkrc");
      gtk_rc_add_default_file (str);
      g_free (str);

      str = g_strdup_printf ("%s%s", g_get_home_dir (), "/.gtkrc");
      gtk_rc_add_default_file (str);
      g_free (str);
    }

Comment 3

[Boris Zbarsky [:bzbarsky]]

OK.  The code that needs fixing seems to be at:

http://lxr.mozilla.org/seamonkey/source/widget/src/gtk/nsAppShell.cpp#256

Comment 4

[Christopher Blizzard (:blizzard)]

Over to dbaron.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Why do we need to call gtk_rc_parse at all?  gtk_init (which we call just above
the mozilla code cited above) calls gtk_rc_init, which should call the function
containing the code pasted above.  Right?

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

If somebody wants to dig into this sooner, feel free (see my comments above). 
It's not a high priority for me right now.

Comment 7

[martin.storsjo]

Well, as dbaron said, it seems like all those gtk_rc_parse-calls are
unnecessary. This patch seems to fix it:

--- mozilla/widget/src/gtk/nsAppShell.cpp.orig	Thu May 24 11:30:16 2001
+++ mozilla/widget/src/gtk/nsAppShell.cpp	Thu May 24 13:36:00 2001
@@ -223,9 +223,6 @@
 
   sInitialized = PR_TRUE;
 
-  gchar *home=nsnull;
-  gchar *path=nsnull;
-
   int argc = bac ? *bac : 0;
   char **argv = bav;
 
@@ -252,15 +249,6 @@
 
   HandleColormapPrefs();
   gdk_rgb_init();
-
-  home = g_get_home_dir();
-  if ((char*)nsnull != home) {
-    path = g_strdup_printf("%s%c%s", home, G_DIR_SEPARATOR, ".gtkrc");
-    if ((char *)nsnull != path) {
-      gtk_rc_parse(path);
-      g_free(path);
-    }
-  }
 
   return NS_OK;
 }

Comment 8

[Stuart Parmenter]

we should verify that in gtk 1.2.0 this was the case.. i expect it wasn't.  we 
should figure out what version of gtk 1.2 added this and ifdef it.

Comment 9

[martin.storsjo]

This gtkrc-loading code looks exactly the same in both gtk-1.2.0 and gtk-1.2.9,
so this should work for at least these releases.

Comment 10

[Christopher Blizzard (:blizzard)]

r=blizzard  Looks fine to me.

Comment 11

[Stuart Parmenter]

ok then, r=pavlov.

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Sorry I didn't get to this sooner.  Moving to 0.9.3, but I really will try to
get it in in the next few days...

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

blizzard said by email that his review could count as a super-review

Comment 14

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2001-07-03 19:12 PDT.

Comment 15

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

*** Bug 91809 has been marked as a duplicate of this bug. ***