805856 - Shutdown CC logging doesn't work any more

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

Maybe I am just doing something silly, but bug 800486 seems to have broken cycle collector logging.

It seems like this line is failing:
  NS_GetSpecialDirectory(NS_OS_TEMP_DIR, getter_AddRefs(logFile));

I seem to be returning here:
  NS_ENSURE_TRUE(logFile, nullptr);

Comment 1

[Andrew McCreight [:mccr8]]

Hmm, so non-shutdown logging seems to be okay, it is just putting it in an annoying directory: /Users/amccreight/Library/Caches/TemporaryItems/cc-edges.49948-1.log

Comment 2

[Justin Lebar (not reading bugmail)]

That's basically an NSPR bug.

Maybe on shutdown we can't even do NS_GetSpecialDirectory.

Comment 3

[Justin Lebar (not reading bugmail)]

> That's basically an NSPR bug.

(The stupid directory on macos, that is.)

Comment 4

[Andrew McCreight [:mccr8]]

Yeah, if it is just on shutdown, it isn't a big deal.  I can work around it.  I was mostly worried about getting user reports.  Though that directory is lame. ;)

Comment 5

[Andrew McCreight [:mccr8]]

This really needs to be fixed, as it is a pain.

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: hacky workaround, not for landing

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: hacky workaround, not for landing, now does JS dump

Comment 8

[Andrew McCreight [:mccr8]]

Attachment: hacky workaround, not for landing

Comment 9

[Andrew McCreight [:mccr8]]

Here's a new twist on this problem... shutdown CC logging now trips shutdown write poisoning...

Comment 10

[Andrew McCreight [:mccr8]]

Filed bug 837197 for the write poisoning issue.

Comment 11

[Andrew McCreight [:mccr8]]

Bill says MOZ_CC_LOG_DIRECTORY works, so that's probably a better option than my patch here.