Currently the "improve firefox os" label in the settings list is a "?" icon, it should be the thumbs up icon.
Priority: -- → P3
Hi Kaze, Eric was updating the settings icons and couldn't find where this icon resides. Can you enlighten us as to its location?
Hi Peter, all icons have been concatenated into one sprite, see: /apps/settings/style/images/icons_sprite.png
(In reply to Fabien Cazenave [:kaze] from comment #3) > Hi Peter, > > all icons have been concatenated into one sprite, see: > /apps/settings/style/images/icons_sprite.png Hi Fabien, Thanks! But the problem is that I don't know where to add the feedback icon in the sprite. Currently Feedback (Improve B2G OS) and Help use the same icon, so if replace it in the sprite the icon will change for both of them instead of just feedback. Hope that makes sense!
Assignee: pla → kaze
blocking-basecamp: --- → ?
Should be fixed in the UX branch
Created attachment 694866 [details] [diff] [review] patch proposal
Attachment #694866 - Flags: review?(etienne)
Comment on attachment 694866 [details] [diff] [review] patch proposal NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): n/a User impact if declined: no icon for the “Improve B2G OS” item Testing completed: manual Risk to taking this patch (and alternatives if risky): none
Attachment #694866 - Flags: approval-gaia-master?(21)
Attachment #694866 - Flags: review?(etienne) → review+
Attachment #694866 - Flags: approval-gaia-master?(21) → approval-gaia-master+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.