Closed
Bug 805941
Opened 13 years ago
Closed 13 years ago
[Settings] Update icon for Feedback to reflect new artwork in App Icon
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P3)
Tracking
(blocking-basecamp:-)
RESOLVED
FIXED
blocking-basecamp | - |
People
(Reporter: pla, Assigned: kaze)
Details
(Keywords: polish, Whiteboard: visual design)
Attachments
(1 file)
651 bytes,
patch
|
etienne
:
review+
vingtetun
:
approval-gaia-v1+
|
Details | Diff | Splinter Review |
No description provided.
Updated•13 years ago
|
Component: Gaia → Gaia::Settings
Comment 1•13 years ago
|
||
Currently the "improve firefox os" label in the settings list is a "?" icon, it should be the thumbs up icon.
Priority: -- → P3
Hi Kaze,
Eric was updating the settings icons and couldn't find where this icon resides. Can you enlighten us as to its location?
Flags: needinfo?(kaze)
Assignee | ||
Comment 3•13 years ago
|
||
Hi Peter,
all icons have been concatenated into one sprite, see:
/apps/settings/style/images/icons_sprite.png
Flags: needinfo?(kaze)
Comment 4•13 years ago
|
||
(In reply to Fabien Cazenave [:kaze] from comment #3)
> Hi Peter,
>
> all icons have been concatenated into one sprite, see:
> /apps/settings/style/images/icons_sprite.png
Hi Fabien,
Thanks! But the problem is that I don't know where to add the feedback icon in the sprite. Currently Feedback (Improve B2G OS) and Help use the same icon, so if replace it in the sprite the icon will change for both of them instead of just feedback. Hope that makes sense!
Assignee | ||
Updated•13 years ago
|
Assignee: pla → kaze
blocking-basecamp: --- → ?
Comment 5•13 years ago
|
||
Should be fixed in the UX branch
Updated•13 years ago
|
blocking-basecamp: ? → -
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #694866 -
Flags: review?(etienne)
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 694866 [details] [diff] [review]
patch proposal
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: no icon for the “Improve B2G OS” item
Testing completed: manual
Risk to taking this patch (and alternatives if risky): none
Attachment #694866 -
Flags: approval-gaia-master?(21)
Updated•13 years ago
|
Attachment #694866 -
Flags: review?(etienne) → review+
Attachment #694866 -
Flags: approval-gaia-master?(21) → approval-gaia-master+
Assignee | ||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•