805941 - [Settings] Update icon for Feedback to reflect new artwork in App Icon

Status: RESOLVED FIXED

Description

[Peter La]

Comment 1

[Patryk Adamczyk [:patryk] UX]

Currently the "improve firefox os" label in the settings list is a "?" icon, it should be the thumbs up icon.

Comment 2

[Peter La]

Hi Kaze,

Eric was updating the settings icons and couldn't find where this icon resides.  Can you enlighten us as to its location?

Comment 3

[Fabien Cazenave [:kaze]]

Hi Peter,

all icons have been concatenated into one sprite, see:
/apps/settings/style/images/icons_sprite.png

Comment 4

[Eric Pang [:epang] UX]

(In reply to Fabien Cazenave [:kaze] from comment #3)
> Hi Peter,
> 
> all icons have been concatenated into one sprite, see:
> /apps/settings/style/images/icons_sprite.png

Hi Fabien,

Thanks!  But the problem is that I don't know where to add the feedback icon in the sprite.  Currently Feedback (Improve B2G OS) and Help use the same icon, so if replace it in the sprite the icon will change for both of them instead of just feedback.  Hope that makes sense!

Comment 5

[David Scravaglieri [:scravag]]

Should be fixed in the UX branch

Comment 6

[Fabien Cazenave [:kaze]]

Created attachment 694866 [details] [diff] [review]
patch proposal

Comment 7

[Fabien Cazenave [:kaze]]

Comment on attachment 694866 [details] [diff] [review]
patch proposal

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: no icon for the “Improve B2G OS” item
Testing completed: manual
Risk to taking this patch (and alternatives if risky): none

Comment 8

[Fabien Cazenave [:kaze]]

https://github.com/mozilla-b2g/gaia/commit/4f9d8e2e397002ef7f14c31378c026ce5cf22370