80598 - View source window does not focus the content area when it's brought up

Status: VERIFIED FIXED

(Core Graveyard :: View Source, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See the 2001-05-12 20:22 comment in bug 78419 for a description of the problem.

Basically, view source currently requires a click in the content area for find
and the like to work....

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: proposed patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

reviews?

Comment 3

[Boris Zbarsky [:bzbarsky]]

r=blake on IRC, but ccing smfr because Blake says that smfr did something so
that this call to focus() should not be needed...

Comment 4

[Blake Ross]

I just remember Simon fixing that bug, but don't know if he fixed it by 
manually focusing the content area in Navigator (as you're doing it here), or 
by focusing the find dialog's parent window from the back end.

Comment 5

[Simon Fraser [no longer active]]

I don't think anything I changed would affect focus in view source. The patch 
seems like a good thing to do.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Alec, could you sr?

Comment 7

[Alec Flett]

sr=alecf

Comment 8

[Blake Ross]

Can someone checkin this patch when the tree opens? Stephen?

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

accepting.  already mailed drivers, and I'll check in when given the go-ahead.

Comment 10

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 11

[(not reading, please use [e-mail] instead)]

Fix checked in.  Thanks to all.

Comment 12

[doctor__j]

Will the fix solve bug 82663?

Comment 13

[Boris Zbarsky [:bzbarsky]]

Yes.

Comment 14

[Eric Hedström]

This is fixed for View Source from a browser window but not from a mail message.
Is that a different bug?

And btw it doesn't fix 82663.

(using 2001061206 win32-installer)

Comment 15

[Boris Zbarsky [:bzbarsky]]

OK.  Read bug 82663 again.  No, this does _not_ fix it.  bug 82663 will get
fixed when Doron lands his view source UI.

"View message source" in mailnews does not use the view source window.  It uses
a window of its own -- that should be a separate bug.

Comment 16

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.06.19.08 comm bits on linux and mac, and 2001.06.19.11
comm bits on winnt.

Comment 17

[Benedikt Kantus]

Reopening. Bug 206398 and bug 199481 both state that this bug exists (again). I
can confirm this with trunk build 2003051908 on Win2k.

Comment 18

[Benedikt Kantus]

*** Bug 206398 has been marked as a duplicate of this bug. ***

Comment 19

[Benedikt Kantus]

Wait! I vcannot reproduce this with the build given aboce. But the bug still
seems to be alive again.

Comment 20

[Boris Zbarsky [:bzbarsky]]

Um... this was refixed a few days ago by Neil... it had a nice separate bug and
all. Resolving fixed, again.

Comment 21

[[e-mail]]

bryner actually (after he regressed it)

Comment 22

[sairuh (rarely reading bugmail)]

w4m with recent builds.