805983 - [Dialer] Pluralize lineContactName

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Staś Małolepszy :stas]

The string added in https://github.com/mozilla-b2g/gaia/commit/6db096605d36ed904250869f131037d665388701 needs to be pluralized correctly.

    +lineContactName={{ name }}... or {{ n }} other

Context: bug 799132 and https://github.com/mozilla-b2g/gaia/pull/5836.  This should have gone through a l10n review, as dialer is string frozen.

Please also include a comment explaining what these variables represent, possibly with an example.

For dev instructions, see:

    https://wiki.mozilla.org/L10n:B2G#Plurals

For a how-to about changing strings after the string freeze, see:

    https://wiki.mozilla.org/L10n:B2G#Changing_strings_after_the_string-freeze

Comment 1

[Staś Małolepszy :stas]

We can't provide good localizations without this fix.

Comment 2

[Alex Keybl [:akeybl]]

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "remaining P1 bugs not already milestoned for C1".

Comment 3

[Alex Keybl [:akeybl]]

Stas brought to our attention that this is actually late-l10n work. Bumping up to C1 (to be completed by Nov19) given that.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 6443

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 682131 [details]
Pull request 6443

r-

Please change the identifier of the strings as per https://wiki.mozilla.org/L10n:B2G/Developers#Changing_strings_after_the_string-freeze

Please put in all 6 plural forms as per https://wiki.mozilla.org/L10n:B2G/Developers#Plurals

And please don't change the French file in git.  The french l10n team works in https://hg.mozilla.org/gaia-l10n/fr

Comment 7

[Alexandre Poirot [:ochameau]]

Comment on attachment 682131 [details]
Pull request 6443

Updated and rebased.
Didn't knew how to see this string to appear?

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 682131 [details]
Pull request 6443

r+.

Stas we need to land that today and I was unable to find you on IRC but the changes here sounds fine from my experience from Fennec.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/6c9e9a60f3b5ea8d1beef3a052683510f59b94ef

Comment 10

[Staś Małolepszy :stas]

Vivien, thanks for covering for me and for reviewing this.  I was on a flight from MozCamp.  The change looks good.  I would have added a comment explaining what this string really means and changed "..." to "…".  I'll fix these issues in bug 812977, so we can leave this bug closed.