805987 - test improvements for bug 803529

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

I meant to name the test better when doing bug 803529, and I also realize now that the test should fail if the `counter` is greater than 2.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/636

Pointer to Github pull-request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Matteo, can you review this one again please? I think I've gotten all of the requested changes.

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

I added some comments, let me know if they make sense to you.
Also, take a look to the comments of the pull request for the bug 805321, that I think are strictly related.

Actually, to me you could just use bug (the bug 805321) to improve all the `attachTo` bugs in the page-mod's test, and this one is part of them. I think should be easier to you to handle them as well.

Let me know what you think.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f848a366b9101b7b4dd7ca7448ca72e3aa40e78d
Merge pull request #636 from erikvold/803529-3

fix bug 805987 test improvements for bug 803529 r=@zer0