Status

Add-on SDK
General
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: erikvold, Assigned: erikvold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I meant to name the test better when doing bug 803529, and I also realize now that the test should fail if the `counter` is greater than 2.
Created attachment 675710 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/636

Pointer to Github pull-request
Attachment #675710 - Flags: review?(zer0)
Assignee: nobody → evold

Updated

6 years ago
Priority: -- → P2
Matteo, can you review this one again please? I think I've gotten all of the requested changes.
I added some comments, let me know if they make sense to you.
Also, take a look to the comments of the pull request for the bug 805321, that I think are strictly related.

Actually, to me you could just use bug (the bug 805321) to improve all the `attachTo` bugs in the page-mod's test, and this one is part of them. I think should be easier to you to handle them as well.

Let me know what you think.

Comment 4

6 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f848a366b9101b7b4dd7ca7448ca72e3aa40e78d
Merge pull request #636 from erikvold/803529-3

fix bug 805987 test improvements for bug 803529 r=@zer0

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Attachment #675710 - Flags: review?(zer0) → review+
You need to log in before you can comment on or make changes to this bug.