Closed
Bug 805987
Opened 12 years ago
Closed 12 years ago
test improvements for bug 803529
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
Details
Attachments
(1 file)
I meant to name the test better when doing bug 803529, and I also realize now that the test should fail if the `counter` is greater than 2.
Assignee | ||
Comment 1•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #675710 -
Flags: review?(zer0)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → evold
Priority: -- → P2
Assignee | ||
Comment 2•12 years ago
|
||
Matteo, can you review this one again please? I think I've gotten all of the requested changes.
Comment 3•12 years ago
|
||
I added some comments, let me know if they make sense to you. Also, take a look to the comments of the pull request for the bug 805321, that I think are strictly related. Actually, to me you could just use bug (the bug 805321) to improve all the `attachTo` bugs in the page-mod's test, and this one is part of them. I think should be easier to you to handle them as well. Let me know what you think.
Comment 4•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/f848a366b9101b7b4dd7ca7448ca72e3aa40e78d Merge pull request #636 from erikvold/803529-3 fix bug 805987 test improvements for bug 803529 r=@zer0
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment #675710 -
Flags: review?(zer0) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•