Closed Bug 805993 Opened 13 years ago Closed 13 years ago

hook up leeroy

Categories

(Marketplace Graveyard :: Code Quality, defect)

Product:
Marketplace Graveyard
Component:
Code Quality
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: andy+bugzilla, Assigned: andy+bugzilla)

Details

github_repo: "mozilla/solitude" jenkins_job_name: "solitude-github" If there's a way we can do this without adding leeroybot to our committers, that would be awesome.
(In reply to Andy McKay [:andym] from comment #0) > If there's a way we can do this without adding leeroybot to our committers, > that would be awesome. I was dragging my feet about this on IRC. Can you talk about what the special hooks are that are being used? I'm just paranoid about more accounts with commit access to the repo.
The service hook listens to pull request actions only. You'd have to do the same thing for Janky or Travis-CI. T-CI uses your existing account + OAuth to set up the hook, but you're still granting their app r/w privileges. Leeroy and Janky both just ask for account credentials. If it helps, LeeroyBot is not a third party. It's my account, set up specifically for this service. I don't think I've made that clear anywhere... will add that to the wiki.
I investigated some more. Leeroy (the app) registers a hook that listens for only pull_request events. Registering a web service manually through the API broadcasts all events, so I could potentially upstream a patch to be more filter out non pull_request events. However the status API also requires write access, so even if we patched the pull_request issue we'd still need an account with write access. The only route to changing this is OAuth, like T-CI, which would use a very restricted scope to allow only writes the status API and not the repo itself. That would be a significant amount of work, though. I modified the wiki with my findings. Wil, Andy -- anything else I can do to ease your concerns? Waiting until I hear back to finish this bug.
Hey Lonnen, can you add a link to the wiki? Sorry, I missed that beer and tell :(
Thanks for the investigation. Go ahead for marketplace - let's see how it goes. Thanks
done. please verify by filing a known good PR and a known bad PR.
Assignee: chris.lonnen → amckay
Could we change to solitude_github please.
Working, thanks.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.