datazilla ts results have more data than they should

RESOLVED FIXED

Status

Testing
Talos
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jeff Hammel, Assigned: jmaher)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
From:

talos -n -d -a ts --develop -e `which firefox` --datazilla-url
foo.json --cycles 5

I get

"""
    "results": {
      "ts": [
        494.0, 
        494.0, 
        420.0, 
        494.0, 
        420.0, 
        438.0, 
        494.0, 
        420.0, 
        438.0, 
        422.0, 
        494.0, 
        420.0, 
        438.0, 
        422.0, 
        441.0
      ]
"""

This should be just 494.0, 420.0, 438.0, 422.0, 441.0 .  We are
wrongly extending vs appending somewhere.
(Assignee)

Comment 1

5 years ago
Created attachment 675858 [details] [diff] [review]
fix datazilla ts tests (1.0)

fix datazilla ts test output.  We might want to extend this to more stuff as well.

Also found a bug in terminate process and I needed to fix this in order to test this.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #675858 - Flags: review?(jhammel)
(Reporter)

Comment 2

5 years ago
Comment on attachment 675858 [details] [diff] [review]
fix datazilla ts tests (1.0)

ABICT, this is a misindentation in the original file.  I'll post a possible fix
Attachment #675858 - Flags: review?(jhammel) → review-
(Reporter)

Comment 3

5 years ago
Created attachment 675866 [details] [diff] [review]
fix indentation level
Attachment #675866 - Flags: review?(jmaher)
(Assignee)

Comment 4

5 years ago
Comment on attachment 675866 [details] [diff] [review]
fix indentation level

Review of attachment 675866 [details] [diff] [review]:
-----------------------------------------------------------------

ahh!
Attachment #675866 - Flags: review?(jmaher) → review+
There was an Android ts improvement of about 8% around Oct 18, which seemed to correspond to a talos.zip update -- might this bug account for that?
(Assignee)

Comment 6

5 years ago
yeah, there is a good chance.
(Reporter)

Comment 7

5 years ago
ABICT, this comes from this changeset: http://hg.mozilla.org/build/talos/rev/e3ab367914e6 .  Of course this doesn't tell when a talos.zip was deployed, but Oct 18 seems a bit out.
(Assignee)

Comment 8

5 years ago
http://hg.mozilla.org/build/talos/rev/c1c4733d4629
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 811361
You need to log in before you can comment on or make changes to this bug.