All users were logged out of Bugzilla on October 13th, 2018

there should be a way to install developer dependencies

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: k0scist, Assigned: wlach)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Currently, building the documentation requires `easy_install sphinx`.
It would be nice if setup_development.py installed this for
convenience.  Additionally, as long as we're going to depend on things
outside of the tree, we could conceivably add other developer
dependencies here, such as a bugzilla REST client so that our workflow
can be more tightly integrated.
Yeah, I think we're going to need to do this. I've got a first cut of a patch.
Assignee: nobody → wlachance
Created attachment 675897 [details] [diff] [review]
Add support for installing sphinx as an extra package
Attachment #675897 - Flags: review?(mcote)
(jhammel would be a more natural choice for reviewer but he's on a flight to Europe) :)
(Reporter)

Comment 4

6 years ago
Comment on attachment 675897 [details] [diff] [review]
Add support for installing sphinx as an extra package

Drive by r+ since I happened to see it.  Looks good to me.

nit:
+extra_packages = [ "sphinx" ]

I would have done
+extra_packages = ["sphinx"]

which I believe is pep-8
Attachment #675897 - Flags: review?(mcote) → review+
Pushed: 

https://github.com/mozilla/mozbase/commit/8e26c4e8bcac15ba3dbc7a2d81f2ff1dcdde0a27
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 6

6 years ago
r+ from me too, FWIW. :)
This broke versionbump.py. Going to attach a small followup patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 678400 [details] [diff] [review]
Fix breakage in versionbump.py

I think this is pretty straightforward.

(again using mcote as a reviewer because jhammel out today)
Attachment #678400 - Flags: review?(mcote)

Comment 9

6 years ago
Comment on attachment 678400 [details] [diff] [review]
Fix breakage in versionbump.py

Review of attachment 678400 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #678400 - Flags: review?(mcote) → review+
Pushed: https://github.com/mozilla/mozbase/commit/d9089a73ef399f250b3ae56aa408942a405886b1
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.