806117 - there should be a way to install developer dependencies

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

Currently, building the documentation requires `easy_install sphinx`.
It would be nice if setup_development.py installed this for
convenience.  Additionally, as long as we're going to depend on things
outside of the tree, we could conceivably add other developer
dependencies here, such as a bugzilla REST client so that our workflow
can be more tightly integrated.

Comment 1

[William Lachance (:wlach)]

Yeah, I think we're going to need to do this. I've got a first cut of a patch.

Comment 2

[William Lachance (:wlach)]

Attachment: Add support for installing sphinx as an extra package

Comment 3

[William Lachance (:wlach)]

(jhammel would be a more natural choice for reviewer but he's on a flight to Europe) :)

Comment 4

[Jeff Hammel]

Comment on attachment 675897 [details] [diff] [review]
Add support for installing sphinx as an extra package

Drive by r+ since I happened to see it.  Looks good to me.

nit:
+extra_packages = [ "sphinx" ]

I would have done
+extra_packages = ["sphinx"]

which I believe is pep-8

Comment 5

[William Lachance (:wlach)]

Pushed: 

https://github.com/mozilla/mozbase/commit/8e26c4e8bcac15ba3dbc7a2d81f2ff1dcdde0a27

Comment 6

[Mark Côté [:mcote]]

r+ from me too, FWIW. :)

Comment 7

[William Lachance (:wlach)]

This broke versionbump.py. Going to attach a small followup patch.

Comment 8

[William Lachance (:wlach)]

Attachment: Fix breakage in versionbump.py

I think this is pretty straightforward.

(again using mcote as a reviewer because jhammel out today)

Comment 9

[Mark Côté [:mcote]]

Comment on attachment 678400 [details] [diff] [review]
Fix breakage in versionbump.py

Review of attachment 678400 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 10

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/mozbase/commit/d9089a73ef399f250b3ae56aa408942a405886b1