Closed Bug 806124 Opened 8 years ago Closed 8 years ago

Services undefined (but used) in connection.js

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
normal

Tracking

(thunderbird18 fixed)

RESOLVED FIXED
Thunderbird 19.0
Tracking Status
thunderbird18 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch proposed fixSplinter Review
Open Network & Disk Space | Connection Settings

Error: Services is not defined
Source File: chrome://messenger/content/preferences/connection.js
Line: 82

From bug 763106.
Attachment #675874 - Flags: review?(acelists)
Comment on attachment 675874 [details] [diff] [review]
proposed fix

Thanks, good catch, patch looks good.
Should be nominated for Aurora?
Attachment #675874 - Flags: review?(mconley)
Attachment #675874 - Flags: review?(acelists)
Attachment #675874 - Flags: feedback+
Attachment #675874 - Flags: review?(mconley) → review+
Keywords: checkin-needed
Comment on attachment 675874 [details] [diff] [review]
proposed fix

[Approval Request Comment]
Regression caused by (bug #): bug 763106
User impact if declined: Preferences->Connection settings not working
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):
Attachment #675874 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/a424b55ad2d4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
Attachment #675874 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.