806231 - Startup crash on windows desktop due to %e date format specifier

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia, defect)

Description

[Josh Matthews [:jdm]]

lockscreen.js passes in %e for the date format, but Windows' strftime doesn't recognize this and crashes.

Comment 1

[Josh Matthews [:jdm]]

http://msdn.microsoft.com/en-us/library/fe06s4ak%28v=vs.80%29.aspx

Comment 2

[Josh Matthews [:jdm]]

As does statusbar.js.

Comment 3

[Josh Matthews [:jdm]]

Attachment: Change all %e to %d

This allows the desktop builds to start for me.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: additional %e -> %d replacement

I found an additional replacement (in apps/homescreen/js/landing.js), but even with this additional change, B2G Desktop still crashes for me on startup.

Comment 5

[Fabien Cazenave [:kaze]]

Comment on attachment 675982 [details] [diff] [review]
Change all %e to %d

Josh, your patch makes sense but %e is not strictly equivalent to %d: for tomorrow’s date (2012-11-01), '%e' gives '1' whereas '%d' gives '01'.

As these date formatters should never be used without the `mozL10n.DateTimeFormat' object provided by the shared `l10n_date.js' library, I think we should:
 • handle this '%e' question in `l10n_date.js';
 • fix the Calendar app to use localized string formats — or simply use %d instead of %e in this app until James internationalizes the date formats in Calendar.

Comment 6

[Mike Connor [:mconnor]]

Not blocking-basecamp on desktop bugs.  Ben has an action to figure out how to track these to support the developer use-case.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Mike: Andrew blocked bug 795484 on the desktop crasher that this purports to fix, and I would expect the two bugs to have similar blocking statuses.

Comment 8

[Josh Matthews [:jdm]]

Myk, if you flip http://mxr.mozilla.org/mozilla-central/source/b2g/app/b2g.js#242 and apply your patch, does B2G start without crashing?

Comment 9

[Myk Melez [:myk] [@mykmelez]]

(In reply to Josh Matthews [:jdm] from comment #8)
> Myk, if you flip
> http://mxr.mozilla.org/mozilla-central/source/b2g/app/b2g.js#242 and apply
> your patch, does B2G start without crashing?

Yes!  However, it also starts without crashing if I flip that pref and *don't* apply my patch, so this bug doesn't affect startup crashes one way or the other in my testing.

Comment 10

[Andrew Overholt [:overholt]]

Did we ever figure out the best way forward here?

Comment 11

[Myk Melez [:myk] [@mykmelez]]

I don't think this is a problem anymore, because B2G no longer crashes on Date.toLocaleFormat('%e').

Also, there are no longer any instances of Date.toLocaleFormat('%e') in Gaia.  Gaia does still use %e extensively, but only via navigator.mozL10n.DateTimeFormat.localeFormat() from l10n_date.js, which does its own replacement, substituting Date.getDate().