The default bug view has changed. See this FAQ.

Update info.plist (register svg files and playable media types, clean up icons)

RESOLVED FIXED in seamonkey2.17

Status

SeaMonkey
OS Integration
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.17
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

5 years ago
In bug 803781, Philip made me aware of that we miss a few updates to our info.plist file:
Bug 650451 - Associate the application with playable media types on Mac.
Bug 474401 - Firefox on Mac does not register itself as being capable of
opening SVG files.

I also think we should use one icon file for all file types - it's much easy to maintain and no-one will ever update the old Mozilla Suite styled .icns files. Lets go for a standard icon with just the seamonkey logo on it.
(Assignee)

Comment 1

5 years ago
Created attachment 675983 [details] [diff] [review]
WIP

What's left here is to check the .icns file and make sure it's OK.
Assignee: nobody → stefanh
(Assignee)

Comment 2

5 years ago
Created attachment 675988 [details] [diff] [review]
Better icon

This one should be better...
Attachment #675983 - Attachment is obsolete: true

Comment 3

5 years ago
Could you split this into two patches, the first one being just whitespace changes? This makes blame easier to look at.
(Assignee)

Comment 4

4 years ago
Created attachment 680573 [details] [diff] [review]
New version

I forgot to change the makefile... But the new .icns file doesn't seem to work - I need to investigate.
Attachment #675988 - Attachment is obsolete: true
(Assignee)

Comment 5

4 years ago
Created attachment 682157 [details] [diff] [review]
Not really any whitespace changes

I reverted my excessive whitespace edits (just removed the empty lines between the <dict>:s) and discovered one missing addition of document.icns. The new icon file seems to work now for me - you might have to run make in the installer dir and then move the package to some other location (not sure, but iirc it's the actuall install, e.g dragging & dropping the .app, that makes the OS aware of the icns files).
Attachment #680573 - Attachment is obsolete: true
Attachment #682157 - Flags: review?(mnyromyr)
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 6

4 years ago
Ah, yeah - I removed a bunch of CFBundleTypeName's since I really didn't see any point having them there (Firefox doesn't have them and I like to remove old stuff that we don't really use - some of those extensions are also unknown to me)

Comment 7

4 years ago
Comment on attachment 682157 [details] [diff] [review]
Not really any whitespace changes

>+	cp $(srcdir)/icons/mac/document.icns          $(DIST)/branding/icons/document.icns
> 	cp $(srcdir)/icons/mac/seamonkey.icns         $(DIST)/branding/icons/seamonkey.icns

Nice to see big icons in document.icns, wouldn't it be useful to have such in seamonkey.icns as well?
Attachment #682157 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 8

4 years ago
(In reply to Karsten Düsterloh from comment #7)
.
.
.
> Nice to see big icons in document.icns, wouldn't it be useful to have such
> in seamonkey.icns as well?

Yeah, it would.
Target Milestone: --- → seamonkey2.17
(Assignee)

Comment 9

4 years ago
http://hg.mozilla.org/comm-central/rev/389b69f005ff
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Duplicate of this bug: 441061
(Assignee)

Updated

4 years ago
Duplicate of this bug: 726488
You need to log in before you can comment on or make changes to this bug.