Closed
Bug 806236
Opened 12 years ago
Closed 12 years ago
Update info.plist (register svg files and playable media types, clean up icons)
Categories
(SeaMonkey :: OS Integration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.17
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
Attachments
(1 file, 3 obsolete files)
218.73 KB,
patch
|
mnyromyr
:
review+
|
Details | Diff | Splinter Review |
In bug 803781, Philip made me aware of that we miss a few updates to our info.plist file: Bug 650451 - Associate the application with playable media types on Mac. Bug 474401 - Firefox on Mac does not register itself as being capable of opening SVG files. I also think we should use one icon file for all file types - it's much easy to maintain and no-one will ever update the old Mozilla Suite styled .icns files. Lets go for a standard icon with just the seamonkey logo on it.
Assignee | ||
Comment 1•12 years ago
|
||
What's left here is to check the .icns file and make sure it's OK.
Assignee: nobody → stefanh
Assignee | ||
Comment 2•12 years ago
|
||
This one should be better...
Attachment #675983 -
Attachment is obsolete: true
Comment 3•12 years ago
|
||
Could you split this into two patches, the first one being just whitespace changes? This makes blame easier to look at.
Assignee | ||
Comment 4•12 years ago
|
||
I forgot to change the makefile... But the new .icns file doesn't seem to work - I need to investigate.
Attachment #675988 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
I reverted my excessive whitespace edits (just removed the empty lines between the <dict>:s) and discovered one missing addition of document.icns. The new icon file seems to work now for me - you might have to run make in the installer dir and then move the package to some other location (not sure, but iirc it's the actuall install, e.g dragging & dropping the .app, that makes the OS aware of the icns files).
Attachment #680573 -
Attachment is obsolete: true
Attachment #682157 -
Flags: review?(mnyromyr)
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•12 years ago
|
||
Ah, yeah - I removed a bunch of CFBundleTypeName's since I really didn't see any point having them there (Firefox doesn't have them and I like to remove old stuff that we don't really use - some of those extensions are also unknown to me)
Comment 7•12 years ago
|
||
Comment on attachment 682157 [details] [diff] [review] Not really any whitespace changes >+ cp $(srcdir)/icons/mac/document.icns $(DIST)/branding/icons/document.icns > cp $(srcdir)/icons/mac/seamonkey.icns $(DIST)/branding/icons/seamonkey.icns Nice to see big icons in document.icns, wouldn't it be useful to have such in seamonkey.icns as well?
Attachment #682157 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Karsten Düsterloh from comment #7) . . . > Nice to see big icons in document.icns, wouldn't it be useful to have such > in seamonkey.icns as well? Yeah, it would.
Target Milestone: --- → seamonkey2.17
Assignee | ||
Comment 9•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/389b69f005ff
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•