806244 - Can't move windows when persona activated

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

STR:
1, create a new profile
2, install a persona, eg https://www.getpersonas.com/en-US/persona/122757
3, restart Firefox

Expected results: windows move with the usual click-drag on the title bar
Actual results: window doesn't move

This is regression in this range:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d1ec228e2ff5&tochange=6332aa884dab

Build before those landed, dragging works:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d1ec228e2ff5
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-macosx64/1351280257/firefox-19.0a1.en-US.mac.dmg

After that push:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6332aa884dab
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-macosx64/1351280856/firefox-19.0a1.en-US.mac.dmg

I've seen this on 10.7.5 and 10.6.8.

Comment 1

[Morpheus3k]

I can confirm this.

Furthermore I've found out that the window can be dragged via the tabbar (while using the light-theme a.k.a Personas)

Comment 2

[Josh Aas]

Any idea what is going on here, Markus?

Comment 3

[Josh Aas]

Taking this for now, but I'm not sure I can fix this before a backout would make more sense.

Comment 4

[Markus Stange [:mstange]]

In Persona mode, there is no movable box installed in the title bar, the title bar is only filled with the window's padding-top (from mxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#29 ). Prior to bug 647216 that didn't make a difference because the window was always draggable in the title bar, but now we actively disable dragging.

I'm not sure yet what the simplest way to fix this is. We should probably back out bug 647216 until we have a plan.

Comment 5

[Markus Stange [:mstange]]

Dão, the xul.css padding-top rule probably needs to go. Should we move the padding-top to some draggable toolbar (like the tabs toolbar in tabs-on-top mode) instead, or should we look into making the CAN_DRAW_IN_TITLEBAR stuff apply on Mac, too? I don't think we want a Firefox button on Mac, so the XUL will need to look differently on Mac anyway so it might not make sense to reuse that code.

Comment 6

[Dão Gottwald [:dao]]

Eventually we need CAN_DRAW_IN_TITLEBAR on Mac for tabs in the title bar. The Firefox button is going away, but for now any code expecting it should depend on MENUBAR_CAN_AUTOHIDE.

Comment 8

[Josh Aas]

Backout isn't clean, I'll have to update it to current trunk.

Comment 9

[Josh Aas]

I have a backout prepared, I'll land it soon.

Who can resolve the issue here? Markus or Dão?

Comment 10

[Josh Aas]

I backed out the patch causing this.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1b1ca54cb42 for posterity.