806282 - SPACE and RETURN should open the popup in type="menu-button" buttons

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Ravi Ranjan]

Attachment: Installing Plugin Allow button menu not accessible

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20100101 Firefox/16.0
Build ID: 20121010144125

Steps to reproduce:

Tried installing a plugin in the Firefox.


Actual results:

An alert is popped by Firefox indicating "Firefox prevented this site...". Pressing Enter or Space keys does not bring the menu under "Allow" button on the panel.


Expected results:

Pressing Enter or Space should bring the menu in the "Allow" button.

Comment 1

[Dão Gottwald [:dao]]

After tabbing to the drop-down part of the button, you need to press Alt+Down.

Comment 2

[alexander :surkov (:asurkov)]

I think they mean standard keyboard shortcuts should work on that button, for example, these are expected shortcuts on windows http://support.microsoft.com/kb/126449

SPACEBAR: If the current control is a button, this clicks the button.
ENTER: Equivalent to clicking the selected button (the button with the outline)

Comment 3

[Ravi Ranjan]

That is right,standard keyboard shortcuts like spacebar does not work.

Comment 4

[alexander :surkov (:asurkov)]

Can we get a progress on this please? It's needed by our partners.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

Comment 6

[Neil Deakin]

Why should space and return open the menu, and not one or the other invoke the command?

Comment 7

[alexander :surkov (:asurkov)]

(In reply to Neil Deakin from comment #6)
> Why should space and return open the menu, and not one or the other invoke
> the command?

what is default action of the button (i.e. what happens when you click it)? Where can I try it? Just in case, isn't it same issue as bug 653226?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Neil Deakin from comment #6)
> Why should space and return open the menu, and not one or the other invoke
> the command?

They invoke the command when the inner button is focused. Right now they do nothing when the dropdown button is focused; that's what this bug is about.

Comment 9

[Dão Gottwald [:dao]]

Enn, is anything still unclear here?

Comment 10

[Ravi Ranjan]

Attachment: Screenshot of the Panel which has defect, with menu shown.

This screenshot shows the menu when user selects using pointer/mouse. However, when the focus on down arrow button and user selects/presses spacebar/enter, the dropdown does not come up.

Comment 11

[Neil Deakin]

I'm unclear why space and return should open the menu. The link in comment 2 doesn't say this at all.

Comment 12

[Dão Gottwald [:dao]]

(In reply to Neil Deakin from comment #11)
> I'm unclear why space and return should open the menu. The link in comment 2
> doesn't say this at all.

Because it's the dropdown button that's focused. See attachment 696683 [details]. It's not clear to me why you think it might be reasonable for space or return to invoke the command here.

Comment 13

[Neil Deakin]

OK, I see what you're referring to. You're implying that the dropmarker is focused when it's actually the outer button that is focused. But that's not how menubuttons should behave and there shouldn't even be two buttons. (I attempted to fix this in bug 653226). On Windows at least they should work the same as split buttons.

Or maybe you're referring to the myriad (and broken) workaround menu-buttons that have been implemented for firefox, in this case probably the one in the install popup which looks different than a default menu-button.

I don't think we should be adding any more behaviour to menu-buttons unless they are actually being properly fixed.

Comment 14

[Dão Gottwald [:dao]]

(In reply to Neil Deakin from comment #13)
> OK, I see what you're referring to. You're implying that the dropmarker is
> focused when it's actually the outer button that is focused. But that's not
> how menubuttons should behave and there shouldn't even be two buttons. (I
> attempted to fix this in bug 653226). On Windows at least they should work
> the same as split buttons.

I'll buy that, but as long as we have two focusable buttons with distinct focus rings et al, adding keyboard accessibility to the outer / menu button seems like a reasonable interim solution to me. Right now there's no easy and discoverable way to open the menu with the keyboard, which is extra bad on top of all the other quirks related to this button type.

Comment 15

[Neil Deakin]

Comment on attachment 694299 [details] [diff] [review]
patch

OK, maybe we'll just try it for now.

Comment 16

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00e758fb0e1e

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/00e758fb0e1e