Last Comment Bug 806305 - unchecked “task” printing, should disable relative settings
: unchecked “task” printing, should disable relative settings
Product: Calendar
Classification: Client Software
Component: Printing (show other bugs)
: Lightning 1.9
: All All
-- normal (vote)
: 2.1
Assigned To: Decathlon
Depends on:
  Show dependency treegraph
Reported: 2012-10-29 01:43 PDT by Vincent (caméléon)
Modified: 2012-11-06 09:11 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch - v1 (2.60 KB, patch)
2012-10-29 07:59 PDT, Decathlon
philipp: review+
Details | Diff | Splinter Review
Patch with calendar-ui-utils file loaded in the dialog (2.86 KB, patch)
2012-11-06 03:39 PST, Decathlon
bv1578: review+
Details | Diff | Splinter Review

Description User image Vincent (caméléon) 2012-10-29 01:43:53 PDT
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20100101 Firefox/15.0 Firefox/15.0
Build ID: 20120824154833

Steps to reproduce:

I unchecked “task” printing

Actual results:

nothing, I can still play with task printing options...

Expected results:

“Task with no due date” and “Completed task” should be grayed and disabled, because they shouldn’t have any impact on the print output.
Comment 1 User image Decathlon 2012-10-29 07:59:50 PDT
Created attachment 676153 [details] [diff] [review]
patch - v1

This patch should fix and also makes persistent the "check" attribute for the checkboxes "events" and "tasks". If this is an unwanted feature, please let me know and I will load a patch without that feature.

Do you think it's worth loading the the file "calendar-ui-utils.js" in order to have the functions setElementValue() or setBooleanAttribute() ?
Comment 2 User image Philipp Kewisch [:Fallen] 2012-11-02 08:48:58 PDT
Comment on attachment 676153 [details] [diff] [review]
patch - v1

Review of attachment 676153 [details] [diff] [review]:

It probably won't hurt to load calendar-ui-utils, we can make use of the other functions in the future too.
Comment 3 User image Decathlon 2012-11-06 03:39:38 PST
Created attachment 678688 [details] [diff] [review]
Patch with calendar-ui-utils file loaded in the dialog

I loaded the calendar-ui-utils.js file and used the setElement() function for the checkboxes.
Setting r+ based on your previous comment. If you want to take a look ...
Comment 4 User image Philipp Kewisch [:Fallen] 2012-11-06 09:10:43 PST
Pushed to comm-central changeset 74d12ca7c43a

Note You need to log in before you can comment on or make changes to this bug.