unchecked “task” printing, should disable relative settings

RESOLVED FIXED in 2.1

Status

Calendar
Printing
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Vincent (caméléon), Assigned: Decathlon)

Tracking

Lightning 1.9

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20100101 Firefox/15.0 Firefox/15.0
Build ID: 20120824154833

Steps to reproduce:

I unchecked “task” printing


Actual results:

nothing, I can still play with task printing options...


Expected results:

“Task with no due date” and “Completed task” should be grayed and disabled, because they shouldn’t have any impact on the print output.
(Assignee)

Comment 1

5 years ago
Created attachment 676153 [details] [diff] [review]
patch - v1

This patch should fix and also makes persistent the "check" attribute for the checkboxes "events" and "tasks". If this is an unwanted feature, please let me know and I will load a patch without that feature.

Do you think it's worth loading the the file "calendar-ui-utils.js" in order to have the functions setElementValue() or setBooleanAttribute() ?
Assignee: nobody → bv1578
Status: NEW → ASSIGNED
Attachment #676153 - Flags: review?(philipp)
Comment on attachment 676153 [details] [diff] [review]
patch - v1

Review of attachment 676153 [details] [diff] [review]:
-----------------------------------------------------------------

It probably won't hurt to load calendar-ui-utils, we can make use of the other functions in the future too.
Attachment #676153 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 678688 [details] [diff] [review]
Patch with calendar-ui-utils file loaded in the dialog

I loaded the calendar-ui-utils.js file and used the setElement() function for the checkboxes.
Setting r+ based on your previous comment. If you want to take a look ...
Attachment #678688 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Pushed to comm-central changeset 74d12ca7c43a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.