Closed
Bug 806340
Opened 12 years ago
Closed 11 years ago
Give more detail for incentives points in performance page
Categories
(Marketplace Graveyard :: Reviewer Tools, enhancement, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
2013-01-24
People
(Reporter: eviljeff, Assigned: robhudson)
References
Details
(Whiteboard: u=rev p=1)
Currently the incentives points on the reviewer /performance pages just show a breakdown down to type of review, e.g. Add-on Review: 1050 App Review: 870 As most reviewers will only do one type of review its effectively just replicating what is seen at the top of the queues. Instead, it would be good to show more detail about the points received this month, year, and all time. (similar to the review performance table in the addons /performance page - but without the total for all editors figure - its not as helpful) so |Addons|Apps|Themes|Total Month | 510 | 450| 0 | 960 Year | 1510 | 450| 0 | 1960 All Time| 2510 |1450| 0 | 3960
Comment 1•12 years ago
|
||
Rob: do we currently just tally the total or do we have stats broken out like this already?
Updated•12 years ago
|
Severity: normal → enhancement
Assignee | ||
Comment 2•12 years ago
|
||
The `ReviewerScore` model has a foreign key to the addon, so we could look at addon.type to determine this... https://github.com/mozilla/zamboni/blob/master/apps/editors/models.py#L362 There's a chance addon_id is NULL, e.g., if the points were awarded manually by an admin.
Assignee | ||
Comment 3•12 years ago
|
||
And the model has the typical created/modified stamps for the month/year totals.
Comment 4•12 years ago
|
||
Ok. We should denormalize this out for speed when we dig into this - add-on types don't change often enough to do JOINs.
Priority: -- → P4
Reporter | ||
Comment 5•12 years ago
|
||
(In reply to Rob Hudson [:robhudson] from comment #2) > The `ReviewerScore` model has a foreign key to the addon, so we could look > at addon.type to determine this... > https://github.com/mozilla/zamboni/blob/master/apps/editors/models.py#L362 > > There's a chance addon_id is NULL, e.g., if the points were awarded manually > by an admin. couldn't it be worked out from the note_key? - point==0, manual; 0<point>40, addon; etc
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Wil Clouser [:clouserw] from comment #4) > Ok. We should denormalize this out for speed when we dig into this - add-on > types don't change often enough to do JOINs. Adding the addon type to this table would be easy, I agree.
Updated•11 years ago
|
Assignee: nobody → robhudson.mozbugs
Target Milestone: --- → 2013-01-17
Assignee | ||
Comment 7•11 years ago
|
||
https://github.com/mozilla/zamboni/commit/0de1ff2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•11 years ago
|
||
looks good. can we get this ported to AMO too? (do we need a separate bug)?
Assignee | ||
Comment 9•11 years ago
|
||
(In reply to Andrew Williamson [:eviljeff] from comment #8) > looks good. can we get this ported to AMO too? (do we need a separate bug)? Oh, oops. I forgot about the AMO side. It should be quick. I'll reopen.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•11 years ago
|
Target Milestone: 2013-01-17 → 2013-01-24
Updated•11 years ago
|
Whiteboard: u=rev p=1
Assignee | ||
Comment 10•11 years ago
|
||
Adding more detail to AMO side: https://github.com/mozilla/zamboni/commit/d37ea5a
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•