806340 - Give more detail for incentives points in performance page

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, enhancement, P4)

Description

[Andrew Williamson [:eviljeff]]

Currently the incentives points on the reviewer /performance pages just show a breakdown down to type of review, e.g.
Add-on Review: 1050
App Review: 870

As most reviewers will only do one type of review its effectively just replicating what is seen at the top of the queues.  Instead, it would be good to show more detail about the points received this month, year, and all time.  (similar to the review performance table in the addons /performance page - but without the total for all editors figure - its not as helpful)

so
        |Addons|Apps|Themes|Total
Month   |  510 | 450|    0 |  960
Year    | 1510 | 450|    0 | 1960
All Time| 2510 |1450|    0 | 3960

Comment 1

[Wil Clouser [:clouserw]]

Rob: do we currently just tally the total or do we have stats broken out like this already?

Comment 2

[Rob Hudson [:robhudson]]

The `ReviewerScore` model has a foreign key to the addon, so we could look at addon.type to determine this...
https://github.com/mozilla/zamboni/blob/master/apps/editors/models.py#L362

There's a chance addon_id is NULL, e.g., if the points were awarded manually by an admin.

Comment 3

[Rob Hudson [:robhudson]]

And the model has the typical created/modified stamps for the month/year totals.

Comment 4

[Wil Clouser [:clouserw]]

Ok.  We should denormalize this out for speed when we dig into this - add-on types don't change often enough to do JOINs.

Comment 5

[Andrew Williamson [:eviljeff]]

(In reply to Rob Hudson [:robhudson] from comment #2)
> The `ReviewerScore` model has a foreign key to the addon, so we could look
> at addon.type to determine this...
> https://github.com/mozilla/zamboni/blob/master/apps/editors/models.py#L362
> 
> There's a chance addon_id is NULL, e.g., if the points were awarded manually
> by an admin.

couldn't it be worked out from the note_key? - point==0, manual; 0<point>40, addon; etc

Comment 6

[Rob Hudson [:robhudson]]

(In reply to Wil Clouser [:clouserw] from comment #4)
> Ok.  We should denormalize this out for speed when we dig into this - add-on
> types don't change often enough to do JOINs.

Adding the addon type to this table would be easy, I agree.

Comment 7

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/0de1ff2

Comment 8

[Andrew Williamson [:eviljeff]]

looks good.  can we get this ported to AMO too?  (do we need a separate bug)?

Comment 9

[Rob Hudson [:robhudson]]

(In reply to Andrew Williamson [:eviljeff] from comment #8)
> looks good.  can we get this ported to AMO too?  (do we need a separate bug)?

Oh, oops. I forgot about the AMO side. It should be quick. I'll reopen.

Comment 10

[Rob Hudson [:robhudson]]

Adding more detail to AMO side:
https://github.com/mozilla/zamboni/commit/d37ea5a