Closed Bug 806349 Opened 8 years ago Closed 8 years ago

Input auto-correction is not enabled

Categories

(Firefox for Android :: Keyboards and IME, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 19

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(2 files)

We are not setting a flag that enables auto-correction. I think we should enable it for text-type inputs.
Attached patch Patch (v1)Splinter Review
Add the auto-correction flag for all text-type inputs
Attachment #676137 - Flags: review?(cpeterson)
Nice spot, well done.
Comment on attachment 676137 [details] [diff] [review]
Patch (v1)

Review of attachment 676137 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM with nit:

::: mobile/android/base/GeckoInputConnection.java
@@ +834,5 @@
> +                outAttrs.inputType |= InputType.TYPE_TEXT_FLAG_CAP_WORDS;
> +            else if (mIMEModeHint.equalsIgnoreCase("autocapitalized"))
> +                outAttrs.inputType |= InputType.TYPE_TEXT_FLAG_CAP_SENTENCES;
> +            // lowercase mode is the default
> +            // else if (mIMEModeHint.equalsIgnoreCase("lowercase"))

The comment about the lowercase default is helpful, but I would remove the code that's commented out. We would never want to check for "lowercase", so I don't think it's useful.
Attachment #676137 - Flags: review?(cpeterson) → review+
https://hg.mozilla.org/mozilla-central/rev/fda4bfed1a1b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.