806349 - Input auto-correction is not enabled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

We are not setting a flag that enables auto-correction. I think we should enable it for text-type inputs.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Patch (v1)

Add the auto-correction flag for all text-type inputs

Comment 2

[Chris Lord [:cwiiis]]

Nice spot, well done.

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 676137 [details] [diff] [review]
Patch (v1)

Review of attachment 676137 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM with nit:

::: mobile/android/base/GeckoInputConnection.java
@@ +834,5 @@
> +                outAttrs.inputType |= InputType.TYPE_TEXT_FLAG_CAP_WORDS;
> +            else if (mIMEModeHint.equalsIgnoreCase("autocapitalized"))
> +                outAttrs.inputType |= InputType.TYPE_TEXT_FLAG_CAP_SENTENCES;
> +            // lowercase mode is the default
> +            // else if (mIMEModeHint.equalsIgnoreCase("lowercase"))

The comment about the lowercase default is helpful, but I would remove the code that's commented out. We would never want to check for "lowercase", so I don't think it's useful.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 806349 - Enable IME auto-correction in Android text fields; r=cpeterson

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fda4bfed1a1b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fda4bfed1a1b