806352 - [Contacts] Sending SMS from contact detail doesn't open Message app in edit mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[David Scravaglieri [:scravag]]

gecko: fa5609f4ae9fb3a70bc76ecaa62307a4ff1496bd
gaia: 58ffd5f5319f865411960f4c81f763a2a4174d71

1- Open existing Contact
2- Tap "Message" button to send a message

Expected:
Open SMS app in edit mode with contact phone number filled.

Actual:
Open SMS app in list mode.

Comment 2

[Faramarz Rashed]

smoke-test failures take highest priority.

Comment 3

[Borja Salguero [:borjasalguero]]

Could you explain the scenario? What do you mean with 'edit-mode'?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Works for me. Please re-open if it still happen.

Comment 5

[John Hammink]

Works for me also on 8/30 build.

Comment 6

[David Scravaglieri [:scravag]]

This issue re-appears in build:

gecko-b2g18: 71fb5406a8f7
gaia: 1eb1c656b3ac608d846b15b15dc13254be5240a7

Comment 7

[Julien Wajsberg [:julienw]]

I think this happens when a thread from said number doesn't exist yet.

I can have a patch today if nobody else comes by.

Comment 8

[Borja Salguero [:borjasalguero]]

Julien! While testing your branch I've fixed this bug in my local branch, so if you merge the other one I can make the PR. The error was in line 149 of the new code, in 'markasunread' because as you said, if the branch does not exist, it's impossible to remove the 'unread' class.

Comment 9

[Julien Wajsberg [:julienw]]

Borja, then just upload your patch here, I'll review it after having merged my patch :)

Marking depending on 822055 so that we don't mess up.

Comment 10

[Borja Salguero [:borjasalguero]]

Attachment: PR

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 696713 [details]
PR

Stealing the review...

Comment 12

[Borja Salguero [:borjasalguero]]

[:etienne] This one now is not bb+, is bb?.... I need approval-gaia-master?

Comment 13

[Borja Salguero [:borjasalguero]]

Comment on attachment 696713 [details]
PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 696713 [details]
PR

This one was blocking+ before beeing reopened. Let's assume this is the same status.

Comment 15

[Julien Wajsberg [:julienw]]

anyway this is a smoketest blocker so..

Comment 16

[Julien Wajsberg [:julienw]]

Borja, I landed Bug 822055, you can go on :)

Comment 17

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/pull/7258 Merged!

Comment 19

[mlevin]

Verified fixed Unagi build 20130102070202.