Closed
Bug 806401
Opened 12 years ago
Closed 12 years ago
android talos reports test_machine as linux|osx instead of android for datazilla
Categories
(Testing :: Talos, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
2.18 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
a bug in our datazilla implementation yields incorrect test_machine information.
Assignee | ||
Comment 1•12 years ago
|
||
this is what we are reporting: "test_machine": { "name": "tegra-314", "os": "linux", "osversion": "Ubuntu 12.04", "platform": "x86_64" }, and this is what we should report: "test_machine": { "name": "tegra-314", "os": "Android", "osversion": "2.3", "platform": "ARMv7" },
Assignee | ||
Comment 2•12 years ago
|
||
while some of this is hacky, it does move is far in the right direction towards data integrity in datazilla.
Comment 3•12 years ago
|
||
Comment on attachment 676175 [details] [diff] [review] use remote logic for results as well as proper version/platform (1.0) How much more work would it really be to do this the "right" way up front? (e.g. contacting the agent for the information) We're going to have to do that eventually anyway and I wonder if we shouldn't just spend the extra hour or whatever to get it right now. That said, as a stopgap this looks ok, minus this minor issue: > # results links >+ if 'tegra' in self.results.title: >+ version = "2.3" Shouldn't this be 2.2?
Attachment #676175 -
Flags: review?(wlachance) → review+
Assignee | ||
Comment 4•12 years ago
|
||
I am fine putting in the extra hour or two needed to resolve this cleaner. The problem is I don't know what is the right solution given our current flow of data. Personally I think pulling the data from the device is the right version. This would be something from sutagent and might require an update. let me play with that a bit and if it is something we can reasonably pull from the device without a new sutagent, I will update the patch. good catch on the version.
Comment 5•12 years ago
|
||
So in theory we should account for this: http://hg.mozilla.org/build/talos/file/95422acc676a/talos/output.py#l494 . It would be nice to know why this code isn't being hit properly.
Assignee | ||
Comment 6•12 years ago
|
||
it is because of: http://hg.mozilla.org/build/talos/file/95422acc676a/talos/results.py#l31. My patch is green on try, I just need to do a better job of auto detecting.
Assignee | ||
Comment 7•12 years ago
|
||
http://hg.mozilla.org/build/talos/rev/3d6510e7c2dd
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•