806544 - [socorro-crashstats] /products page broken

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

Traceback (most recent call last):

  File "/data/socorro-crashstats/vendor/lib/python/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/socorro-crashstats/crashstats/crashstats/views.py", line 155, in inner
    return view(request, *args, **kwargs)

  File "/data/socorro-crashstats/crashstats/crashstats/views.py", line 251, in products_list
    return render(request, 'crashstats/products_list.html', data)

  File "/data/socorro-crashstats/vendor/lib/python/django/shortcuts/__init__.py", line 44, in render
    return HttpResponse(loader.render_to_string(*args, **kwargs),

  File "/data/socorro-crashstats/vendor/lib/python/django/template/loader.py", line 176, in render_to_string
    return t.render(context_instance)

  File "/data/socorro-crashstats/vendor/src/jingo/jingo/__init__.py", line 189, in render
    return super(Template, self).render(context_dict)

  File "/data/socorro-crashstats/vendor-local/lib/python/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/socorro-crashstats/crashstats/crashstats/templates/crashstats/products_list.html", line 1, in top-level template code
    {% extends "crashstats_base.html" %}

  File "/data/socorro-crashstats/crashstats/base/templates/crashstats_base.html", line 142, in top-level template code
    {% block content %}{% endblock %}

  File "/data/socorro-crashstats/crashstats/crashstats/templates/crashstats/products_list.html", line 17, in block "content"
    <li><a href="{{ url('crashstats.home', product['product_name']) }}">{{ product['product_name'] }}</a></li>

  File "/data/socorro-crashstats/vendor/src/funfactory/funfactory/helpers.py", line 32, in url
    return reverse(viewname, args=args, kwargs=kwargs)

  File "/data/socorro-crashstats/vendor/src/funfactory/funfactory/urlresolvers.py", line 28, in reverse
    url = django_reverse(viewname, urlconf, args, kwargs, prefix)

  File "/data/socorro-crashstats/vendor/lib/python/django/core/urlresolvers.py", line 476, in reverse
    return iri_to_uri(resolver._reverse_with_prefix(view, prefix, *args, **kwargs))

  File "/data/socorro-crashstats/vendor/lib/python/django/core/urlresolvers.py", line 396, in _reverse_with_prefix
    "arguments '%s' not found." % (lookup_view_s, args, kwargs))

NoReverseMatch: Reverse for 'crashstats.home' with arguments '(Undefined,)' and keyword arguments '{}' not found.

Comment 1

[Robert Helmer [:rhelmer]]

https://github.com/mozilla/socorro-crashstats/pull/245

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/e3a473c4b714e56a5bd687570d980233366c049c
fixes bug 806544 - structure of /products mware service changed, but we should have been using the simple products list in here, anyway

https://github.com/mozilla/socorro-crashstats/commit/f274cb711c7b23c194419f4357ca475d0a657690
Merge pull request #245 from rhelmer/bug806544-products-page-broken

fixes bug 806544 - structure of /products mware service changed, but we ...

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

[10:46:51.080] GET http://crash-stats-new-dev.allizom.org/products/ [HTTP/1.1 200 OK 861ms]