Last Comment Bug 806581 - Translate Facebook Chat
: Translate Facebook Chat
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: 18 Branch
: x86_64 Windows 7
: -- normal (vote)
: Thunderbird 19.0
Assigned To: Andreas Pettersson
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-29 14:58 PDT by Andreas Pettersson
Modified: 2012-11-02 13:01 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Facebook Chat label (1.22 KB, patch)
2012-10-30 10:52 PDT, Andreas Pettersson
clokep: feedback+
Details | Diff | Splinter Review
Facebook chat name (1.23 KB, patch)
2012-10-30 11:05 PDT, Andreas Pettersson
clokep: review+
Details | Diff | Splinter Review

Description Andreas Pettersson 2012-10-29 14:58:36 PDT
Create a new chat account. 

Facebook chat is not a proper name, it has a Swedish translation. The name is hardcoded in file http://mxr.mozilla.org/comm-central/source/chat/protocols/facebook/facebook.js#49
Comment 1 Ludovic Hirlimann [:Usul] 2012-10-30 05:00:11 PDT
Could you come up with a patch ?
Comment 2 Andreas Pettersson 2012-10-30 10:52:18 PDT
Created attachment 676675 [details] [diff] [review]
Facebook Chat label
Comment 3 Patrick Cloke [:clokep] 2012-10-30 10:56:26 PDT
Comment on attachment 676675 [details] [diff] [review]
Facebook Chat label

>diff --git a/chat/locales/en-US/facebook.properties b/chat/locales/en-US/facebook.properties
> FacebookProtocol.prototype = {
>   __proto__: GenericProtocolPrototype,
>   get normalizedName() "facebook",
>-  get name() "Facebook Chat",
>+  get name() "network.label",
You'll need to call the translation function like on http://mxr.mozilla.org/comm-central/source/chat/protocols/facebook/facebook.js#32, so this would be _("network.label"). I don't find this name to be very descriptive, however. Maybe something like "facebook.name"?

Would we want to do this for all of our JS protocols? (GTalk, Facebook, XMPP, IRC, Twitter) Florian?

Also, I wonder why Facebook have its own properties file, GTalk just has its strings inside of xmpp.properties...
Comment 4 Andreas Pettersson 2012-10-30 11:05:19 PDT
Created attachment 676677 [details] [diff] [review]
Facebook chat name
Comment 5 Patrick Cloke [:clokep] 2012-10-30 13:40:17 PDT
Comment on attachment 676677 [details] [diff] [review]
Facebook chat name

I'll test this out later tonight.
Comment 6 Patrick Cloke [:clokep] 2012-11-01 19:41:02 PDT
Comment on attachment 676677 [details] [diff] [review]
Facebook chat name

Looks good to me! Thanks. :)
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-11-02 13:01:18 PDT
https://hg.mozilla.org/comm-central/rev/b11e3f92b12b

Thanks for the patch! One request - to make life easier for those checking in on your behalf, please make sure that your future patches follow the guidelines below so that all the necessary checkin metadata is present. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Note You need to log in before you can comment on or make changes to this bug.