Translate Facebook Chat

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Andreas Pettersson, Assigned: Andreas Pettersson)

Tracking

18 Branch
Thunderbird 19.0
x86_64
Windows 7
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Create a new chat account. 

Facebook chat is not a proper name, it has a Swedish translation. The name is hardcoded in file http://mxr.mozilla.org/comm-central/source/chat/protocols/facebook/facebook.js#49
Could you come up with a patch ?
(Assignee)

Comment 2

5 years ago
Created attachment 676675 [details] [diff] [review]
Facebook Chat label
Comment on attachment 676675 [details] [diff] [review]
Facebook Chat label

>diff --git a/chat/locales/en-US/facebook.properties b/chat/locales/en-US/facebook.properties
> FacebookProtocol.prototype = {
>   __proto__: GenericProtocolPrototype,
>   get normalizedName() "facebook",
>-  get name() "Facebook Chat",
>+  get name() "network.label",
You'll need to call the translation function like on http://mxr.mozilla.org/comm-central/source/chat/protocols/facebook/facebook.js#32, so this would be _("network.label"). I don't find this name to be very descriptive, however. Maybe something like "facebook.name"?

Would we want to do this for all of our JS protocols? (GTalk, Facebook, XMPP, IRC, Twitter) Florian?

Also, I wonder why Facebook have its own properties file, GTalk just has its strings inside of xmpp.properties...
Attachment #676675 - Flags: feedback+
(Assignee)

Comment 4

5 years ago
Created attachment 676677 [details] [diff] [review]
Facebook chat name
Attachment #676675 - Attachment is obsolete: true
Comment on attachment 676677 [details] [diff] [review]
Facebook chat name

I'll test this out later tonight.
Attachment #676677 - Flags: review?(clokep)
Comment on attachment 676677 [details] [diff] [review]
Facebook chat name

Looks good to me! Thanks. :)
Attachment #676677 - Flags: review?(clokep) → review+
Assignee: nobody → az
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/b11e3f92b12b

Thanks for the patch! One request - to make life easier for those checking in on your behalf, please make sure that your future patches follow the guidelines below so that all the necessary checkin metadata is present. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.