Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Translate Facebook Chat

RESOLVED FIXED in Thunderbird 19.0


Instant Messaging
5 years ago
5 years ago


(Reporter: Andreas Pettersson, Assigned: Andreas Pettersson)


18 Branch
Thunderbird 19.0
Windows 7
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)



(1 attachment, 1 obsolete attachment)



5 years ago
Create a new chat account. 

Facebook chat is not a proper name, it has a Swedish translation. The name is hardcoded in file
Could you come up with a patch ?

Comment 2

5 years ago
Created attachment 676675 [details] [diff] [review]
Facebook Chat label
Comment on attachment 676675 [details] [diff] [review]
Facebook Chat label

>diff --git a/chat/locales/en-US/ b/chat/locales/en-US/
> FacebookProtocol.prototype = {
>   __proto__: GenericProtocolPrototype,
>   get normalizedName() "facebook",
>-  get name() "Facebook Chat",
>+  get name() "network.label",
You'll need to call the translation function like on, so this would be _("network.label"). I don't find this name to be very descriptive, however. Maybe something like ""?

Would we want to do this for all of our JS protocols? (GTalk, Facebook, XMPP, IRC, Twitter) Florian?

Also, I wonder why Facebook have its own properties file, GTalk just has its strings inside of
Attachment #676675 - Flags: feedback+

Comment 4

5 years ago
Created attachment 676677 [details] [diff] [review]
Facebook chat name
Attachment #676675 - Attachment is obsolete: true
Comment on attachment 676677 [details] [diff] [review]
Facebook chat name

I'll test this out later tonight.
Attachment #676677 - Flags: review?(clokep)
Comment on attachment 676677 [details] [diff] [review]
Facebook chat name

Looks good to me! Thanks. :)
Attachment #676677 - Flags: review?(clokep) → review+
Assignee: nobody → az
Ever confirmed: true
Keywords: checkin-needed

Thanks for the patch! One request - to make life easier for those checking in on your behalf, please make sure that your future patches follow the guidelines below so that all the necessary checkin metadata is present. Thanks!
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.