806581 - Translate Facebook Chat

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Andreas Pettersson]

Create a new chat account. 

Facebook chat is not a proper name, it has a Swedish translation. The name is hardcoded in file http://mxr.mozilla.org/comm-central/source/chat/protocols/facebook/facebook.js#49

Comment 1

[Ludovic Hirlimann [:Usul]]

Could you come up with a patch ?

Comment 2

[Andreas Pettersson]

Attachment: Facebook Chat label

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 676675 [details] [diff] [review]
Facebook Chat label

>diff --git a/chat/locales/en-US/facebook.properties b/chat/locales/en-US/facebook.properties
> FacebookProtocol.prototype = {
>   __proto__: GenericProtocolPrototype,
>   get normalizedName() "facebook",
>-  get name() "Facebook Chat",
>+  get name() "network.label",
You'll need to call the translation function like on http://mxr.mozilla.org/comm-central/source/chat/protocols/facebook/facebook.js#32, so this would be _("network.label"). I don't find this name to be very descriptive, however. Maybe something like "facebook.name"?

Would we want to do this for all of our JS protocols? (GTalk, Facebook, XMPP, IRC, Twitter) Florian?

Also, I wonder why Facebook have its own properties file, GTalk just has its strings inside of xmpp.properties...

Comment 4

[Andreas Pettersson]

Attachment: Facebook chat name

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 676677 [details] [diff] [review]
Facebook chat name

I'll test this out later tonight.

Comment 6

[Patrick Cloke [:clokep]]

Comment on attachment 676677 [details] [diff] [review]
Facebook chat name

Looks good to me! Thanks. :)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/b11e3f92b12b

Thanks for the patch! One request - to make life easier for those checking in on your behalf, please make sure that your future patches follow the guidelines below so that all the necessary checkin metadata is present. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in