806591 - Add function to generate UUIDs

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, defect)

Description

[Gregory Szorc [:gps]]

Attachment: Add CommonUtils.generateUUID()

Add CommonUtils.generateUUID().

Comment 1

[Richard Newman [:rnewman]]

Comment on attachment 676361 [details] [diff] [review]
Add CommonUtils.generateUUID()

Review of attachment 676361 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/common/tests/unit/test_utils_uuid.js
@@ +5,5 @@
> +
> +function run_test() {
> +  let uuid = CommonUtils.generateUUID();
> +  do_check_eq(uuid.length, 36);
> +  do_check_eq(uuid[8], "-");

Your function comment says "with no extra characters". One of you is lying :D

::: services/common/utils.js
@@ +472,5 @@
> +   * Generate a new UUID.
> +   *
> +   * Returns a hex-formatted UUID string with no extra characters (like {}).
> +   *
> +   * @return string

This comment should probably be:

  Generate a new UUID using nsiUUIDGenerator, removing extraneous
  characters such as [{}].

  Example: "..."

  @return (string) a hex-formatted UUID string.

::: services/healthreport/service.jsm
@@ +115,5 @@
>      // TODO pull namespace from prefs
>      // TODO Generate UUID for ID
>      // TODO delete old ID if present.
> +    let promise = client.uploadJSON("healthreport", "foobar",
> +                                    this._getJSONPayload());

Pretty sure this snuck in by mistake.

Comment 2

[Gregory Szorc [:gps]]

https://hg.mozilla.org/projects/larch/rev/fb3d94492902

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 676361 [details] [diff] [review]
Add CommonUtils.generateUUID()

Bulk-setting approval flags for FHR landing for FxOS ADU ping (Bug 788894).

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86b0762e70ed

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/86b0762e70ed

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 676361 [details] [diff] [review]
Add CommonUtils.generateUUID()

FHR for B2G ADU ping, won't be built/enabled for Mobile/Desktop.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e3f2f2c9f6ad
https://hg.mozilla.org/releases/mozilla-beta/rev/a05896ac7000