80663 - Column picker not working

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Chris Lyon]

Using build 2001051308 on Win2K

Steps to Reproduce:
1. Open any window or dialog in the browser that has column view
2. Click the column picker

Results:
Nothing happens.  Also, the column picker is missing its icon.

Comment 1

[Fabian Guisset]

Yummy, going to look at what broke this!

Comment 2

[Asa Dotzler [:asa]]

worksforme with 051504 mozilla build on win2K.  I opened Bookmark Manager window
and clicked on each of the column headers.  The header sorted the column as
expected. Am I misinterpreting this report?  (another good reason to always
include clear and specific steps to reproduce your issue in the report).

Comment 3

[doctor__j]

Attachment: Screenshot of the "column picker"

Comment 4

[Asa Dotzler [:asa]]

I see it.  Not a problem in mailnews threadpane but it is a problem in history
and bookmarks (maybe elsewhere). Confirmed with 051504 mozilla build on win2K.
Over to XPApps GUI Features.

Comment 5

[Fabian Guisset]

This regressed between the 11 and 12 of may. Right in time for stylesheet 
coping. Hear hear.

Comment 6

[Blake Ross]

Cool, thanks for finding that.  Does that mean I can blame hewitt now?

Comment 7

[Claudius Gayle]

bug 71776 is nsbeta1+ and TM 0.9.1 and can't be verified until this bug is fixed. That would seem
to require this bug be similarily triaged and assigned a Target Milestone.

Comment 8

[Fabian Guisset]

I am hitting a dead end here. Both classic and modern have this problem. I
couldn't find any obvious flaws in the files. I did find something strange,
although probably unrelated: http://lxr.mozilla.org/seamonkey/search?string=tree.css
this query shows that the modern skin doesn't import tree.css at all (unless I'm
missing something obvious). However the classic skin imports tree.css, and it
still doesn't work, so it can't be the real problem. 
Hewitt could you tell us how you replaced all the css files in the modern skin?
(outliner.css, tree.css, etc, aren't used anywhere)
Thanks in advance.

Comment 9

[Joe Hewitt (gone)]

This looks like a XUL problem.  I tried removing the <image/> inside of the
column picker in bookmarks, and that solved caused the column picker to work
again.  Of course, the image is needed so we can display the icon.  If we were
using Blake's column picker widget (from outliner) we wouldn't have this problem.

Comment 10

[Claudius Gayle]

grrr, there's no other way to change columns and I can't test anything
related to the columns i can't see!
I see that joe has done some investigation - I'm just wondering where the
triage status is b/c there's no ns+ and no Target Milestone. WHa assurances
do I have that this bugfix will make it into a beta/milstone release?

Comment 11

[David Hyatt]

My guess is that someone has screwed up the child insertion points in the XBL.

Comment 12

[hangas]

Marking 0.9.2, Hyatt thinks this is a bug in the XBL.  We should have an icon 
there or people will not discover this feature.

Comment 13

[Claudius Gayle]

it's not just 'discoverability', simply put - it don't work.
clicking the space shows the 'clicked' styling but nothing else happens

Comment 14

[Todd Pringle]

themes triage:  leaving in 0.9.2 bucket - need to fix this or the functionality
is broken, marking nsbeta1+

Comment 15

[hangas]

PDT has approved this bug for 0.9.2

Comment 16

[Fabian Guisset]

OK I still think this is Hewitt's bug. Here's why.
In historyTreeOverlay.xul and bookmarks.xul, changing 
<image class="treecell-popup-icon"/>
to
<image src="chrome://global/skin/tree/columnpicker.gif"/>
makes it work again. 
However there is a little problem, the menu does not open reliably, i.e.
sometimes it gets three tries to open it, but it's really a minor issue compared
to not being able to open it at all.
Attaching two patches (changes in my tree are too big to make a single patch),
one for history and one for bookmarks.

Keep in mind that they are workarounds. The real issue is that the rule in
tree.css is not being called, or incorrectly called, or whatever. That sounds
too complicated for me anyway.

Comment 17

[Fabian Guisset]

Attachment: patch to history, also add a class to copy the bookmarks tree

Comment 18

[Fabian Guisset]

Attachment: patch to bookmarks.xul.

Comment 19

[Joe Hewitt (gone)]

I have a fix for this - but I don't like it.  I can't wait for these stupid
hacked up column pickers to go away when bookmarks and history switch to outliner.

Comment 20

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 21

[andreww]

Comments:   
1) missing newline issues with menu.css - modern,classic mac, classic 
win
2) extra space in global.css

r=andreww  with comments above

Comment 22

[Fabian Guisset]

i wish this could be achieved without killing third-party skins.
If this is checked in I'll post a message to npm.ui to tell the skin guys about
this. Patch looks good however.

Comment 23

[Blake Ross]

sr=blake

Comment 24

[Asa Dotzler [:asa]]

approval noted in the bug.

--Asa

Comment 25

[Joe Hewitt (gone)]

fixed

Comment 26

[Joe Hewitt (gone)]

can't bugzilla read my mind and change the resolution when I say "fixed"?

Comment 27

[Claudius Gayle]

niiice. glory be. VERIFIED Fixed with 2001061404 builds. i checked bookmarks
manger, global history, and the history sidebar tab